ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-04 17:23:45 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix more floating promises (#8374)

Browse Source 
* Fix more floating promises

* Fix a few more

* Test fixes

* Fix spellings

* More promise fixes

* couple more

* Few more fixes

* One more missed one
This commit is contained in:
Charles Gagnon
2019-11-18 17:11:25 -08:00
committed by GitHub
parent 840683e3f0
commit 5b50696a1b
8 changed files with 231 additions and 348 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/services/profiler/browser/interfaces.ts
View File

@@ -139,7 +139,7 @@ export interface IProfilerService {
* Saves the filter
* @param filter filter object
*/
saveFilter(filter: ProfilerFilter): void;
saveFilter(filter: ProfilerFilter): Promise<void>;
}
export interface IProfilerSettings {

4
src/sql/workbench/services/profiler/browser/profilerService.ts
View File

@@ -245,8 +245,8 @@ export class ProfilerService implements IProfilerService {
return config;
}
public saveFilter(filter: ProfilerFilter): void {
public async saveFilter(filter: ProfilerFilter): Promise<void> {
const config = [filter];
this._configurationService.updateValue(PROFILER_FILTER_SETTINGS, config, ConfigurationTarget.USER);
await this._configurationService.updateValue(PROFILER_FILTER_SETTINGS, config, ConfigurationTarget.USER);
}
}