add null check for errors in the console while using query editor (#15711)

* add null check

* another null check

* pr comments

* update typing
This commit is contained in:
Alan Ren
2021-06-15 16:05:38 -07:00
committed by GitHub
parent a8f3d97f59
commit 5bd1552a59
4 changed files with 7 additions and 6 deletions

View File

@@ -201,7 +201,7 @@ export class QueryResultsView extends Disposable {
private hasResults(runner: QueryRunner): boolean {
let hasResults = false;
for (const batch of runner.batchSets) {
if (batch.resultSetSummaries.length > 0) {
if (batch.resultSetSummaries?.length > 0) {
hasResults = true;
break;
}

View File

@@ -193,11 +193,12 @@ export class RowCountStatusBarContributions extends Disposable implements IWorkb
}
}
private _displayValue(runner: QueryRunner) {
private _displayValue(runner: QueryRunner): void {
const rowCount = runner.batchSets.reduce((p, c) => {
return p + c.resultSetSummaries.reduce((rp, rc) => {
const cnt = c.resultSetSummaries?.reduce((rp, rc) => {
return rp + rc.rowCount;
}, 0);
}, 0) ?? 0;
return p + cnt;
}, 0);
const text = localize('rowCount', "{0} rows", rowCount.toLocaleString());
this.statusItem.update({ text, ariaLabel: text });