ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Converting all SQL MIAA commands to use K8s API commands (#20203)

Browse Source 
* refresh does not differentiate direct vs indirect

* For direct mode MIAA commands, always use --use-k8s

* Changed comment language to use ARM instead of direct and K8S API instead of indirect

Co-authored-by: Candice Ye <canye@microsoft.com>
This commit is contained in:
Candice Ye
2022-08-02 11:12:25 -07:00
committed by GitHub
parent 8f5b3ef81d
commit 5d23627165
9 changed files with 92 additions and 212 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
extensions/azcli/src/api.ts
View File

@@ -117,9 +117,9 @@ export function getAzApi(localAzDiscovered: Promise<IAzTool | undefined>, azTool
delete: async (
name: string,
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string;
// Indirect mode arguments
// K8s API arguments
namespace?: string;
},
additionalEnvVars?: azExt.AdditionalEnvVars
@@ -130,9 +130,9 @@ export function getAzApi(localAzDiscovered: Promise<IAzTool | undefined>, azTool
},
list: async (
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string;
// Indirect mode arguments
// K8s API arguments
namespace?: string;
},
additionalEnvVars?: azExt.AdditionalEnvVars
@@ -144,9 +144,9 @@ export function getAzApi(localAzDiscovered: Promise<IAzTool | undefined>, azTool
show: async (
name: string,
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string;
// Indirect mode arguments
// K8s API arguments
namespace?: string;
},
// Additional arguments
@@ -166,9 +166,9 @@ export function getAzApi(localAzDiscovered: Promise<IAzTool | undefined>, azTool
noWait?: boolean;
syncSecondaryToCommit?: string;
},
// Direct mode arguments
// ARM API arguments
resourceGroup?: string,
// Indirect mode arguments
// K8s API arguments
namespace?: string,
usek8s?: boolean,
// Additional arguments
@@ -181,9 +181,9 @@ export function getAzApi(localAzDiscovered: Promise<IAzTool | undefined>, azTool
upgrade: async (
name: string,
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string;
// Indirect mode arguments
// K8s API arguments
namespace?: string;
},
// Additional arguments

22
extensions/azcli/src/az.ts
View File

@@ -116,7 +116,7 @@ export class AzTool implements azExt.IAzApi {
const argsArray = ['arcdata', 'dc', 'upgrade', '--desired-version', desiredVersion, '--name', name];
// Direct mode argument
if (resourceGroup) { argsArray.push('--resource-group', resourceGroup); }
// Indirect mode arguments
// K8s API arguments
if (namespace) {
argsArray.push('--k8s-namespace', namespace);
argsArray.push('--use-k8s');
@@ -180,9 +180,9 @@ export class AzTool implements azExt.IAzApi {
delete: (
name: string,
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string,
// Indirect mode arguments
// K8s API arguments
namespace?: string
// Additional arguments
},
@@ -200,9 +200,9 @@ export class AzTool implements azExt.IAzApi {
},
list: (
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string,
// Indirect mode arguments
// K8s API arguments
namespace?: string
// Additional arguments
},
@@ -221,9 +221,9 @@ export class AzTool implements azExt.IAzApi {
show: (
name: string,
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string,
// Indirect mode arguments
// K8s API arguments
namespace?: string
// Additional arguments
},
@@ -250,9 +250,9 @@ export class AzTool implements azExt.IAzApi {
retentionDays?: string,
syncSecondaryToCommit?: string
},
// Direct mode arguments
// ARM API arguments
resourceGroup?: string,
// Indirect mode arguments
// K8s API arguments
namespace?: string,
usek8s?: boolean,
// Additional arguments
@@ -273,9 +273,9 @@ export class AzTool implements azExt.IAzApi {
upgrade: (
name: string,
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string,
// Indirect mode arguments
// K8s API arguments
namespace?: string
// Additional arguments
},

20
extensions/azcli/src/typings/az-ext.d.ts vendored
View File

@@ -575,9 +575,9 @@ declare module 'az-ext' {
delete(
name: string,
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string,
// Indirect mode arguments
// K8s API arguments
namespace?: string
},
// Additional arguments
@@ -585,9 +585,9 @@ declare module 'az-ext' {
): Promise<AzOutput<void>>,
list(
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string,
// Indirect mode arguments
// K8s API arguments
namespace?: string
},
// Additional arguments
@@ -596,9 +596,9 @@ declare module 'az-ext' {
show(
name: string,
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string,
// Indirect mode arguments
// K8s API arguments
namespace?: string
},
// Additional arguments
@@ -615,9 +615,9 @@ declare module 'az-ext' {
retentionDays?: string, //5
syncSecondaryToCommit?: string //2
},
// Direct mode arguments
// ARM API arguments
resourceGroup?: string,
// Indirect mode arguments
// K8s API arguments
namespace?: string,
usek8s?: boolean,
// Additional arguments
@@ -626,9 +626,9 @@ declare module 'az-ext' {
upgrade(
name: string,
args: {
// Direct mode arguments
// ARM API arguments
resourceGroup?: string,
// Indirect mode arguments
// K8s API arguments
namespace?: string
},
// Additional arguments