ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-18 09:35:39 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL Migration] Fix assessment UI issues (#20733)

Browse Source 
* Clarify assessment results in card

* Fix incorrect number of dbs ready for migration without issues to MI

* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues

* Update error banner for blocked databases

* Reword error message
This commit is contained in:
Raymond Truong
2022-10-05 16:57:49 -07:00
committed by GitHub
parent 1e89df8955
commit 5da4f449d4
3 changed files with 27 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
extensions/sql-migration/src/wizard/skuRecommendationPage.ts
View File

@@ -616,7 +616,14 @@ export class SKURecommendationPage extends MigrationWizardPage {
}
const dbCount = this.migrationStateModel._assessmentResults?.databaseAssessments?.length;
const dbWithoutIssuesCount = this.migrationStateModel._assessmentResults?.databaseAssessments?.filter(db => db.issues?.length === 0).length;
const dbWithoutIssuesForMiCount = this.migrationStateModel._assessmentResults?.databaseAssessments?.filter(db =>
!db.issues?.some(issue => issue.appliesToMigrationTargetPlatform === MigrationTargetType.SQLMI)
).length;
const dbWithoutIssuesForVmCount = dbCount;
const dbWithoutIssuesForDbCount = this.migrationStateModel._assessmentResults?.databaseAssessments?.filter(db =>
!db.issues?.some(issue => issue.appliesToMigrationTargetPlatform === MigrationTargetType.SQLDB)
).length;
this._supportedProducts.forEach((product, index) => {
if (!this.migrationStateModel._assessmentResults) {
this._rbg.cards[index].descriptions[CardDescriptionIndex.ASSESSMENT_STATUS].textValue = '';
@@ -646,7 +653,7 @@ export class SKURecommendationPage extends MigrationWizardPage {
switch (product.type) {
case MigrationTargetType.SQLMI:
this._rbg.cards[index].descriptions[CardDescriptionIndex.ASSESSMENT_STATUS].textValue =
constants.CAN_BE_MIGRATED(dbWithoutIssuesCount, dbCount);
constants.CAN_BE_MIGRATED(dbWithoutIssuesForMiCount, dbCount);
if (this.hasRecommendations()) {
if (this.migrationStateModel._skuEnableElastic) {
@@ -681,7 +688,7 @@ export class SKURecommendationPage extends MigrationWizardPage {
case MigrationTargetType.SQLVM:
this._rbg.cards[index].descriptions[CardDescriptionIndex.ASSESSMENT_STATUS].textValue =
constants.CAN_BE_MIGRATED(dbCount, dbCount);
constants.CAN_BE_MIGRATED(dbWithoutIssuesForVmCount, dbCount);
if (this.hasRecommendations()) {
// elastic model currently doesn't support SQL VM, so show the baseline model results regardless of user preference
@@ -718,7 +725,7 @@ export class SKURecommendationPage extends MigrationWizardPage {
case MigrationTargetType.SQLDB:
this._rbg.cards[index].descriptions[CardDescriptionIndex.ASSESSMENT_STATUS].textValue =
constants.CAN_BE_MIGRATED(dbWithoutIssuesCount, dbCount);
constants.CAN_BE_MIGRATED(dbWithoutIssuesForDbCount, dbCount);
if (this.hasRecommendations()) {
const recommendations = this.migrationStateModel._skuEnableElastic