From 5de8d824178d20e69d1f49aba33ce47ef6f17071 Mon Sep 17 00:00:00 2001 From: stuti149 <87131830+stuti149@users.noreply.github.com> Date: Fri, 15 Oct 2021 02:38:24 +0530 Subject: [PATCH] update extension to use new offlineConfiguratin and offline property names (#17316) --- extensions/sql-migration/src/api/azure.ts | 10 +++++----- extensions/sql-migration/src/constants/helper.ts | 2 +- .../dialog/migrationCutover/migrationCutoverDialog.ts | 2 +- extensions/sql-migration/src/models/stateMachine.ts | 10 +++++----- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/extensions/sql-migration/src/api/azure.ts b/extensions/sql-migration/src/api/azure.ts index dfd8902ff2..8a0668d059 100644 --- a/extensions/sql-migration/src/api/azure.ts +++ b/extensions/sql-migration/src/api/azure.ts @@ -289,7 +289,7 @@ export async function getMigrationStatus(account: azdata.Account, subscription: if (migration.properties) { migrationUpdate.properties.sourceDatabaseName = migration.properties.sourceDatabaseName; migrationUpdate.properties.backupConfiguration = migration.properties.backupConfiguration; - migrationUpdate.properties.autoCutoverConfiguration = migration.properties.autoCutoverConfiguration; + migrationUpdate.properties.offlineConfiguration = migration.properties.offlineConfiguration; } return migrationUpdate; @@ -423,7 +423,7 @@ export interface StartDatabaseMigrationRequest { password: string }, scope: string, - autoCutoverConfiguration: AutoCutoverConfiguration, + offlineConfiguration: OfflineConfiguration, } } @@ -453,7 +453,7 @@ export interface DatabaseMigrationProperties { migrationService: string; migrationOperationId: string; backupConfiguration: BackupConfiguration; - autoCutoverConfiguration: AutoCutoverConfiguration; + offlineConfiguration: OfflineConfiguration; migrationFailureError: ErrorInfo; } export interface MigrationStatusDetails { @@ -487,8 +487,8 @@ export interface BackupConfiguration { targetLocation?: TargetLocation; } -export interface AutoCutoverConfiguration { - autoCutover: boolean; +export interface OfflineConfiguration { + offline: boolean; lastBackupName?: string; } diff --git a/extensions/sql-migration/src/constants/helper.ts b/extensions/sql-migration/src/constants/helper.ts index bad1071738..43b8ce0906 100644 --- a/extensions/sql-migration/src/constants/helper.ts +++ b/extensions/sql-migration/src/constants/helper.ts @@ -23,5 +23,5 @@ export function getMigrationTargetType(migration: MigrationContext): string { } export function getMigrationMode(migration: MigrationContext): string { - return migration.migrationContext.properties.autoCutoverConfiguration?.autoCutover?.valueOf() ? loc.OFFLINE : loc.OFFLINE; + return migration.migrationContext.properties.offlineConfiguration?.offline?.valueOf() ? loc.OFFLINE : loc.OFFLINE; } diff --git a/extensions/sql-migration/src/dialog/migrationCutover/migrationCutoverDialog.ts b/extensions/sql-migration/src/dialog/migrationCutover/migrationCutoverDialog.ts index 3048a3e7c0..5f666edce9 100644 --- a/extensions/sql-migration/src/dialog/migrationCutover/migrationCutoverDialog.ts +++ b/extensions/sql-migration/src/dialog/migrationCutover/migrationCutoverDialog.ts @@ -802,7 +802,7 @@ export class MigrationCutoverDialog { } private _isOnlineMigration(): boolean { - return this._model._migration.migrationContext.properties.autoCutoverConfiguration?.autoCutover?.valueOf() ? false : true; + return this._model._migration.migrationContext.properties.offlineConfiguration?.offline?.valueOf() ? false : true; } private _shouldDisplayBackupFileTable(): boolean { diff --git a/extensions/sql-migration/src/models/stateMachine.ts b/extensions/sql-migration/src/models/stateMachine.ts index d5ed21beaa..83d8cfb814 100644 --- a/extensions/sql-migration/src/models/stateMachine.ts +++ b/extensions/sql-migration/src/models/stateMachine.ts @@ -911,8 +911,8 @@ export class MigrationStateModel implements Model, vscode.Disposable { password: this._sqlServerPassword }, scope: this._targetServerInstance.id, - autoCutoverConfiguration: { - autoCutover: isOfflineMigration + offlineConfiguration: { + offline: isOfflineMigration } } }; @@ -933,8 +933,8 @@ export class MigrationStateModel implements Model, vscode.Disposable { }; if (isOfflineMigration) { - requestBody.properties.autoCutoverConfiguration = { - autoCutover: isOfflineMigration, + requestBody.properties.offlineConfiguration = { + offline: isOfflineMigration, lastBackupName: this._databaseBackup.blobs[i]?.lastBackupFile }; } @@ -967,7 +967,7 @@ export class MigrationStateModel implements Model, vscode.Disposable { ); response.databaseMigration.properties.sourceDatabaseName = this._migrationDbs[i]; response.databaseMigration.properties.backupConfiguration = requestBody.properties.backupConfiguration!; - response.databaseMigration.properties.autoCutoverConfiguration = requestBody.properties.autoCutoverConfiguration!; + response.databaseMigration.properties.offlineConfiguration = requestBody.properties.offlineConfiguration!; if (response.status === 201 || response.status === 200) { sendSqlMigrationActionEvent(