From 5f2d8b2bd5f1d23176c6bea7a4f1ad1bf708e1d7 Mon Sep 17 00:00:00 2001
From: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Date: Thu, 10 Mar 2022 18:11:49 -0800
Subject: [PATCH] remove sql server 2005 and 2008 as options for sql database
 projects (#18664)

* remove sql server 2005 and 2008 from target platforms

* also remove 2005 and 2008 from SqlTargetPlatform enum

* fix a windows test
---
 extensions/sql-database-projects/src/common/constants.ts      | 2 --
 extensions/sql-database-projects/src/sqldbproj.d.ts           | 2 --
 extensions/sql-database-projects/src/test/buildHelper.test.ts | 2 +-
 3 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/extensions/sql-database-projects/src/common/constants.ts b/extensions/sql-database-projects/src/common/constants.ts
index 44e9450998..2c1ccb47b2 100644
--- a/extensions/sql-database-projects/src/common/constants.ts
+++ b/extensions/sql-database-projects/src/common/constants.ts
@@ -510,8 +510,6 @@ export function differentDbDifferentServerExampleUsage(server: string, db: strin
 
 // Target platforms
 export const targetPlatformToVersion: Map<string, string> = new Map<string, string>([
-	[SqlTargetPlatform.sqlServer2005, '90'],
-	[SqlTargetPlatform.sqlServer2008, '100'],
 	[SqlTargetPlatform.sqlServer2012, '110'],
 	[SqlTargetPlatform.sqlServer2014, '120'],
 	[SqlTargetPlatform.sqlServer2016, '130'],
diff --git a/extensions/sql-database-projects/src/sqldbproj.d.ts b/extensions/sql-database-projects/src/sqldbproj.d.ts
index cd4a69b8cd..da5fa395d1 100644
--- a/extensions/sql-database-projects/src/sqldbproj.d.ts
+++ b/extensions/sql-database-projects/src/sqldbproj.d.ts
@@ -173,8 +173,6 @@ declare module 'sqldbproj' {
 	 * Target platforms for a sql project
 	 */
 	export const enum SqlTargetPlatform {
-		sqlServer2005 = 'SQL Server 2005',
-		sqlServer2008 = 'SQL Server 2008',
 		sqlServer2012 = 'SQL Server 2012',
 		sqlServer2014 = 'SQL Server 2014',
 		sqlServer2016 = 'SQL Server 2016',
diff --git a/extensions/sql-database-projects/src/test/buildHelper.test.ts b/extensions/sql-database-projects/src/test/buildHelper.test.ts
index 5c689fd5c6..bac2c04923 100644
--- a/extensions/sql-database-projects/src/test/buildHelper.test.ts
+++ b/extensions/sql-database-projects/src/test/buildHelper.test.ts
@@ -30,7 +30,7 @@ describe('BuildHelper: Build Helper tests', function (): void {
 		const resultArg = buildHelper.constructBuildArguments('dummy\\project path\\more space in path', 'dummy\\dll path', true);
 
 		if (os.platform() === 'win32') {
-			should(resultArg).equal(' build "dummy\\\\project path\\\\more space in path" /p:NetCoreBuild=true /p:SystemDacpacsLocation=="dummy\\\\dll path"');
+			should(resultArg).equal(' build "dummy\\\\project path\\\\more space in path" /p:NetCoreBuild=true /p:SystemDacpacsLocation="dummy\\\\dll path"');
 		}
 		else {
 			should(resultArg).equal(' build "dummy/project path/more space in path" /p:NetCoreBuild=true /p:SystemDacpacsLocation="dummy/dll path"');