From 5f59fa021cb3d5ead6ce9ab44c688ac19df38c05 Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Mon, 5 Oct 2020 12:53:59 -0700 Subject: [PATCH] Fix checkbox change event not firing on enter press (#12703) (#12735) * Fix checkbox change event not firing * Add comment --- src/sql/base/browser/ui/checkbox/checkbox.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/sql/base/browser/ui/checkbox/checkbox.ts b/src/sql/base/browser/ui/checkbox/checkbox.ts index bad9ce3655..8c1016ca68 100644 --- a/src/sql/base/browser/ui/checkbox/checkbox.ts +++ b/src/sql/base/browser/ui/checkbox/checkbox.ts @@ -48,6 +48,9 @@ export class Checkbox extends Widget { this.onkeydown(this._el, e => { if (e.equals(KeyCode.Enter)) { this.checked = !this.checked; + // Manually fire the event since we stop the event propagation which means + // the onchange event won't fire. + this._onChange.fire(this.checked); e.stopPropagation(); } });