From 5f8e1f384f181a74d8f82a7e62ca5221990994c9 Mon Sep 17 00:00:00 2001 From: Alan Ren Date: Fri, 5 Nov 2021 16:26:17 -0700 Subject: [PATCH] table designer editor icon (#17608) * icon for table designer * use more specific name * use sql defined schema --- extensions/theme-seti/icons/images/table.svg | 1 + extensions/theme-seti/icons/vs-seti-icon-theme.json | 4 ++++ src/sql/base/common/schemas.ts | 11 +++++++++++ .../editor/tableDesigner/tableDesignerInput.ts | 10 +++++++--- 4 files changed, 23 insertions(+), 3 deletions(-) create mode 100644 extensions/theme-seti/icons/images/table.svg create mode 100644 src/sql/base/common/schemas.ts diff --git a/extensions/theme-seti/icons/images/table.svg b/extensions/theme-seti/icons/images/table.svg new file mode 100644 index 0000000000..025d9bd136 --- /dev/null +++ b/extensions/theme-seti/icons/images/table.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/extensions/theme-seti/icons/vs-seti-icon-theme.json b/extensions/theme-seti/icons/vs-seti-icon-theme.json index 73d63da6e0..7cc67b1de2 100644 --- a/extensions/theme-seti/icons/vs-seti-icon-theme.json +++ b/extensions/theme-seti/icons/vs-seti-icon-theme.json @@ -1517,6 +1517,9 @@ }, "scmp_dark": { "iconPath": "./images/scmp_inverse.svg" + }, + "table-designer": { + "iconPath": "./images/table.svg" } }, "file": "_default", @@ -1809,6 +1812,7 @@ "dashboard": "_shell", "profiler": "_csv", "Schema Compare": "scmp_dark", + "table-designer": "table-designer" }, "languageIds": { "bat": "_windows", diff --git a/src/sql/base/common/schemas.ts b/src/sql/base/common/schemas.ts new file mode 100644 index 0000000000..d6b9627671 --- /dev/null +++ b/src/sql/base/common/schemas.ts @@ -0,0 +1,11 @@ +/*--------------------------------------------------------------------------------------------- + * Copyright (c) Microsoft Corporation. All rights reserved. + * Licensed under the Source EULA. See License.txt in the project root for license information. + *--------------------------------------------------------------------------------------------*/ + +export namespace Schemas { + /** + * A schema that is used for table designer editor + */ + export const tableDesigner = 'ads-table-designer'; +} diff --git a/src/sql/workbench/browser/editor/tableDesigner/tableDesignerInput.ts b/src/sql/workbench/browser/editor/tableDesigner/tableDesignerInput.ts index 3f22a38cfa..41865d723c 100644 --- a/src/sql/workbench/browser/editor/tableDesigner/tableDesignerInput.ts +++ b/src/sql/workbench/browser/editor/tableDesigner/tableDesignerInput.ts @@ -4,8 +4,8 @@ *--------------------------------------------------------------------------------------------*/ import { localize } from 'vs/nls'; +import { URI } from 'vs/base/common/uri'; import { EditorInput } from 'vs/workbench/common/editor/editorInput'; -import { URI } from 'vs/workbench/workbench.web.api'; import { TableDesignerComponentInput } from 'sql/workbench/services/tableDesigner/browser/tableDesignerComponentInput'; import { TableDesignerProvider } from 'sql/workbench/services/tableDesigner/common/interface'; import * as azdata from 'azdata'; @@ -13,6 +13,7 @@ import { GroupIdentifier, IEditorInput, IRevertOptions, ISaveOptions } from 'vs/ import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { onUnexpectedError } from 'vs/base/common/errors'; +import { Schemas } from 'sql/base/common/schemas'; const NewTable: string = localize('tableDesigner.newTable', "New Table"); @@ -52,8 +53,11 @@ export class TableDesignerInput extends EditorInput { return TableDesignerInput.ID; } - get resource(): URI { - return undefined; + public get resource(): URI { + return URI.from({ + scheme: Schemas.tableDesigner, + path: 'table-designer' + }); } public getComponentInput(): TableDesignerComponentInput {