ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixes/cleanup for datavirtualization (#21608)

Browse Source 
* Fixes/cleanup for datavirtualization

* Update owners
This commit is contained in:
Charles Gagnon
2023-01-17 11:42:26 -08:00
committed by GitHub
parent 68cbff38f4
commit 60147c1a86
4 changed files with 7 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/datavirtualization/src/services/serviceClient.ts
View File

@@ -47,7 +47,7 @@ export class ServiceClient {
const processStart = Date.now();
client.onReady().then(() => {
const processEnd = Date.now();
this.statusView.text = localize('serviceStarted', 'Service Started');
this.statusView.text = localize('serviceStarted', '{0} started', Constants.serviceName);
setTimeout(() => {
this.statusView.hide();
}, 1500);
@@ -59,13 +59,13 @@ export class ServiceClient {
});
});
this.statusView.show();
this.statusView.text = localize('serviceStarting', 'Starting service');
this.statusView.text = localize('serviceStarting', 'Starting {0}...', Constants.serviceName);
let disposable = client.start();
context.subscriptions.push(disposable);
resolve();
}, e => {
Telemetry.sendTelemetryEvent('ServiceInitializingFailed');
this.apiWrapper.showErrorMessage(localize('serviceStartFailed', 'Failed to start Scale Out Data service:{0}', e));
this.apiWrapper.showErrorMessage(localize('serviceStartFailed', 'Failed to start {0}: {1}', Constants.serviceName, e));
// Just resolve to avoid unhandled promise. We show the error to the user.
resolve();
});

21
extensions/datavirtualization/src/wizards/wizardCommands.ts
View File

@@ -96,24 +96,7 @@ export class OpenMssqlHdfsTableFromFileWizardCommand extends Command {
}
function convertIConnectionProfile(profile: azdata.IConnectionProfile): azdata.connection.ConnectionProfile {
let connection: azdata.connection.ConnectionProfile;
if (profile) {
connection = {
providerId: profile.providerName,
connectionId: profile.id,
connectionName: profile.connectionName,
serverName: profile.serverName,
databaseName: profile.databaseName,
userName: profile.userName,
password: profile.password,
authenticationType: profile.authenticationType,
savePassword: profile.savePassword,
groupFullName: profile.groupFullName,
groupId: profile.groupId,
saveProfile: profile.saveProfile,
azureTenantId: profile.azureTenantId,
options: {}
};
}
const connection = azdata.connection.ConnectionProfile.createFrom(profile.options);
connection.providerId = profile.providerName;
return connection;
}