ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixes/cleanup for datavirtualization (#21608)

Browse Source 
* Fixes/cleanup for datavirtualization

* Update owners
This commit is contained in:
Charles Gagnon
2023-01-17 11:42:26 -08:00
committed by GitHub
parent 68cbff38f4
commit 60147c1a86
4 changed files with 7 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.github/CODEOWNERS vendored
View File

@@ -7,6 +7,7 @@
/extensions/azcli/ @Charles-Gagnon @swells @candiceye /extensions/azcli/ @Charles-Gagnon @swells @candiceye
/extensions/azurecore/ @cssuh @cheenamalhotra /extensions/azurecore/ @cssuh @cheenamalhotra
/extensions/dacpac/ @kisantia /extensions/dacpac/ @kisantia
/extensions/datavirtualization @Charles-Gagnon
/extensions/notebook @azure-data-studio-notebook-devs /extensions/notebook @azure-data-studio-notebook-devs
/extensions/query-history/ @Charles-Gagnon /extensions/query-history/ @Charles-Gagnon
/extensions/resource-deployment/ @Charles-Gagnon /extensions/resource-deployment/ @Charles-Gagnon

11
extensions/datavirtualization/config.json
View File

@@ -5,16 +5,7 @@
"Windows_64": "win-x64.zip", "Windows_64": "win-x64.zip",
"Windows_86": "win-x86.zip", "Windows_86": "win-x86.zip",
"OSX": "osx-x64.tar.gz", "OSX": "osx-x64.tar.gz",
"Linux_64": "linux-x64.tar.gz", "Linux": "linux-x64.tar.gz"
"CentOS_7": "linux-x64.tar.gz",
"Debian_8": "linux-x64.tar.gz",
"Fedora_23": "linux-x64.tar.gz",
"OpenSUSE_13_2": "linux-x64.tar.gz",
"RHEL_7": "linux-x64.tar.gz",
"SLES_12_2": "linux-x64.tar.gz",
"Ubuntu_14": "linux-x64.tar.gz",
"Ubuntu_16": "linux-x64.tar.gz",
"Ubuntu_18": "linux-x64.tar.gz"
}, },
"installDirectory": "scaleoutdataservice/{#platform#}/{#version#}", "installDirectory": "scaleoutdataservice/{#platform#}/{#version#}",
"executableFiles": [ "executableFiles": [

6
extensions/datavirtualization/src/services/serviceClient.ts
View File

@@ -47,7 +47,7 @@ export class ServiceClient {
const processStart = Date.now(); const processStart = Date.now();
client.onReady().then(() => { client.onReady().then(() => {
const processEnd = Date.now(); const processEnd = Date.now();
this.statusView.text = localize('serviceStarted', 'Service Started'); this.statusView.text = localize('serviceStarted', '{0} started', Constants.serviceName);
setTimeout(() => { setTimeout(() => {
this.statusView.hide(); this.statusView.hide();
}, 1500); }, 1500);
@@ -59,13 +59,13 @@ export class ServiceClient {
}); });
}); });
this.statusView.show(); this.statusView.show();
this.statusView.text = localize('serviceStarting', 'Starting service'); this.statusView.text = localize('serviceStarting', 'Starting {0}...', Constants.serviceName);
let disposable = client.start(); let disposable = client.start();
context.subscriptions.push(disposable); context.subscriptions.push(disposable);
resolve(); resolve();
}, e => { }, e => {
Telemetry.sendTelemetryEvent('ServiceInitializingFailed'); Telemetry.sendTelemetryEvent('ServiceInitializingFailed');
this.apiWrapper.showErrorMessage(localize('serviceStartFailed', 'Failed to start Scale Out Data service:{0}', e)); this.apiWrapper.showErrorMessage(localize('serviceStartFailed', 'Failed to start {0}: {1}', Constants.serviceName, e));
// Just resolve to avoid unhandled promise. We show the error to the user. // Just resolve to avoid unhandled promise. We show the error to the user.
resolve(); resolve();
}); });

21
extensions/datavirtualization/src/wizards/wizardCommands.ts
View File

@@ -96,24 +96,7 @@ export class OpenMssqlHdfsTableFromFileWizardCommand extends Command {
} }
function convertIConnectionProfile(profile: azdata.IConnectionProfile): azdata.connection.ConnectionProfile { function convertIConnectionProfile(profile: azdata.IConnectionProfile): azdata.connection.ConnectionProfile {
let connection: azdata.connection.ConnectionProfile; const connection = azdata.connection.ConnectionProfile.createFrom(profile.options);
if (profile) { connection.providerId = profile.providerName;
connection = {
providerId: profile.providerName,
connectionId: profile.id,
connectionName: profile.connectionName,
serverName: profile.serverName,
databaseName: profile.databaseName,
userName: profile.userName,
password: profile.password,
authenticationType: profile.authenticationType,
savePassword: profile.savePassword,
groupFullName: profile.groupFullName,
groupId: profile.groupId,
saveProfile: profile.saveProfile,
azureTenantId: profile.azureTenantId,
options: {}
};
}
return connection; return connection;
} }