ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-08 01:28:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix a bunch of strict issues (#11857)

Browse Source 
* fix a bunch of strict issues

* fix tests

* fix tests
This commit is contained in:
Anthony Dresser
2020-08-19 10:37:30 -07:00
committed by GitHub
parent e90341b3d2
commit 60c62c0668
20 changed files with 100 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/base/test/browser/ui/scrollableView/scrollableView.test.ts
View File

@@ -20,7 +20,7 @@ class TestView extends Disposable implements IView {
this._onDidLayout.fire({ height, width });
}
private _size: number;
private _size: number = 0;
public get size(): number {
return this._size;
}
@@ -135,7 +135,7 @@ suite('ScrollableView', () => {
assert.equal(view1.size, 100, 'view1 is minimum size');
assert.equal(view2.size, 100, 'view2 is minimum size');
assert.equal(view3.size, undefined, 'view3 should not have been layout yet');
assert.equal(view3.size, 0, 'view3 should not have been layout yet');
});
test('reacts to changes in views', async () => {
@@ -157,7 +157,7 @@ suite('ScrollableView', () => {
assert.equal(view1.size, 130, 'view1 should be 130');
assert.equal(view2.size, 100, 'view2 should still be minimum size');
assert.equal(view3.size, undefined, 'view3 should not have been layout yet');
assert.equal(view3.size, 0, 'view3 should not have been layout yet');
});
test('programmatically scrolls', async () => {
@@ -174,7 +174,7 @@ suite('ScrollableView', () => {
assert.equal(view1.size, 100, 'view1 is minimum size');
assert.equal(view2.size, 100, 'view2 is minimum size');
assert.equal(view3.size, undefined, 'view3 should not have been layout yet');
assert.equal(view3.size, 0, 'view3 should not have been layout yet');
assert.equal(getViewChildren(container).length, 2, 'only 2 views are rendered');
scrollableView.setScrollTop(100);

14
src/sql/base/test/browser/ui/selectBox/selectBox.test.ts
View File

@@ -16,13 +16,13 @@ const options: SelectOptionItemSQL[] = [
suite('Select Box tests', () => {
test('default value', () => {
const sb = new SelectBox(options, options[1].value, undefined, undefined, undefined);
const sb = new SelectBox(options, options[1].value, undefined!, undefined!, undefined!);
assert(sb.value === options[1].value);
});
test('values change', () => {
const sb = new SelectBox(options, options[1].value, undefined, undefined, undefined);
const sb = new SelectBox(options, options[1].value, undefined!, undefined!, undefined!);
const newOptions = deepClone(options);
{
const moreOptions: SelectOptionItemSQL[] = [
@@ -38,7 +38,7 @@ suite('Select Box tests', () => {
});
test('the selected option changes', () => {
const sb = new SelectBox(options, options[1].value, undefined, undefined, undefined);
const sb = new SelectBox(options, options[1].value, undefined!, undefined!, undefined!);
sb.onSelect({
index: 0,
@@ -50,16 +50,16 @@ suite('Select Box tests', () => {
});
test('values get auto populated', () => {
const newOptions = deepClone(options).map(s => { return { text: s.text, value: undefined }; });
const sb = new SelectBox(newOptions, undefined, undefined, undefined, undefined);
const newOptions = deepClone(options).map(s => { return { text: s.text, value: s.text }; });
const sb = new SelectBox(newOptions, undefined!, undefined!, undefined!, undefined!);
assert(equals(sb.values, newOptions.map(s => s.text)));
});
test('value did not contain label', () => {
const newOptions = deepClone(options).map(s => { return { text: s.text, value: undefined }; });
const newOptions = deepClone(options).map(s => { return { text: s.text, value: s.text }; });
delete newOptions[0].text;
const sb = new SelectBox(newOptions, undefined, undefined, undefined, undefined);
const sb = new SelectBox(newOptions, undefined!, undefined!, undefined!, undefined!);
sb.onSelect({