ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-08 01:28:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix a bunch of strict issues (#11857)

Browse Source 
* fix a bunch of strict issues

* fix tests

* fix tests
This commit is contained in:
Anthony Dresser
2020-08-19 10:37:30 -07:00
committed by GitHub
parent e90341b3d2
commit 60c62c0668
20 changed files with 100 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/sql/platform/accounts/common/accountActions.ts
View File

@@ -58,6 +58,7 @@ export class AddAccountAction extends Action {
this.logService.error(`Error while adding account: ${err}`);
this._addAccountErrorEmitter.fire(err);
this._addAccountCompleteEmitter.fire();
return false;
}));
}
}

4
src/sql/platform/accounts/test/common/testAccountManagementService.ts
View File

@@ -56,7 +56,7 @@ export class TestAccountManagementService implements IAccountManagementService {
}
getAccountSecurityToken(account: azdata.Account, tenant: string, resource: azdata.AzureResource): Thenable<{ token: string }> {
return Promise.resolve(undefined);
return Promise.resolve(undefined!);
}
removeAccount(accountKey: azdata.AccountKey): Thenable<boolean> {
@@ -105,7 +105,7 @@ export class AccountProviderStub implements azdata.AccountProvider {
}
getAccountSecurityToken(account: azdata.Account, tenant: string, resource: azdata.AzureResource): Thenable<{ token: string }> {
return Promise.resolve(undefined);
return Promise.resolve(undefined!);
}
initialize(storedAccounts: azdata.Account[]): Thenable<azdata.Account[]> {
return Promise.resolve(storedAccounts);

2
src/sql/platform/connection/test/common/connectionProfile.test.ts
View File

@@ -187,7 +187,7 @@ suite('SQL ConnectionProfileInfo tests', () => {
});
test('createFromStoredProfile should set the id to new guid if not set in stored profile', () => {
let savedProfile = assign({}, storedProfile, { id: undefined });
let savedProfile: IConnectionProfileStore = assign({}, storedProfile, { id: undefined });
let connectionProfile = ConnectionProfile.createFromStoredProfile(savedProfile, capabilitiesService);
assert.equal(savedProfile.groupId, connectionProfile.groupId);
assert.deepEqual(savedProfile.providerName, connectionProfile.providerName);

16
src/sql/platform/connection/test/common/testConfigurationService.ts
View File

@@ -33,14 +33,16 @@ export class TestConfigurationService implements IConfigurationService {
let _target: 'user' | 'workspace' = (target as ConfigurationTarget) === ConfigurationTarget.USER ? 'user' : 'workspace';
let keyArray = key.split('.');
let targetObject = this.configuration[_target];
for (let i = 0; i < keyArray.length; i++) {
if (i === keyArray.length - 1) {
targetObject[keyArray[i]] = value;
} else {
if (!targetObject[keyArray[i]]) {
targetObject[keyArray[i]] = {};
if (targetObject) {
for (let i = 0; i < keyArray.length; i++) {
if (i === keyArray.length - 1) {
targetObject![keyArray[i]] = value;
} else {
if (!targetObject![keyArray[i]]) {
targetObject![keyArray[i]] = {};
}
targetObject = targetObject![keyArray[i]];
}
targetObject = targetObject[keyArray[i]];
}
}
return Promise.resolve(void 0);

2
src/sql/platform/connection/test/common/testConnectionManagementService.ts
View File

@@ -260,7 +260,7 @@ export class TestConnectionManagementService implements IConnectionManagementSer
}
getConnectionCredentials(profileId: string): Promise<{ [name: string]: string }> {
return Promise.resolve(undefined);
return Promise.resolve(undefined!);
}
getServerInfo(profileId: string): azdata.ServerInfo {

23
src/sql/platform/opener/common/openerServiceStub.ts
View File

@@ -3,15 +3,26 @@
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import { URI } from 'vs/base/common/uri';
import { IOpenerService } from 'vs/platform/opener/common/opener';
import { IOpenerService, IOpener, IValidator, IExternalUriResolver, IExternalOpener, ResolveExternalUriOptions, IResolvedExternalUri } from 'vs/platform/opener/common/opener';
import { IDisposable } from 'vs/base/common/lifecycle';
export class OpenerServiceStub implements IOpenerService {
registerOpener(opener: IOpener): IDisposable {
throw new Error('Method not implemented.');
}
registerValidator(validator: IValidator): IDisposable {
throw new Error('Method not implemented.');
}
registerExternalUriResolver(resolver: IExternalUriResolver): IDisposable {
throw new Error('Method not implemented.');
}
setExternalOpener(opener: IExternalOpener): void {
throw new Error('Method not implemented.');
}
resolveExternalUri(resource: URI, options?: ResolveExternalUriOptions): Promise<IResolvedExternalUri> {
throw new Error('Method not implemented.');
}
_serviceBrand: undefined;
registerOpener() { return undefined; }
registerValidator() { return undefined; }
registerExternalUriResolver() { return undefined; }
setExternalOpener() { return undefined; }
async open(resource: URI | string, options?: any): Promise<boolean> { return Promise.resolve(true); }
async resolveExternalUri(uri: any) { return undefined; }
}

4
src/sql/platform/serialization/common/serializationService.ts
View File

@@ -157,7 +157,7 @@ export class SerializationService implements ISerializationService {
private createStartRequest(serializationRequest: SerializeDataParams, index: number): azdata.SerializeDataStartRequestParams {
let batchSize = getBatchSize(serializationRequest.rowCount, index);
let rows = serializationRequest.getRowRange(index, serializationRequest.includeHeaders, batchSize);
let rows = serializationRequest.getRowRange(index, serializationRequest.includeHeaders ?? false, batchSize);
let columns: azdata.SimpleColumnInfo[] = serializationRequest.columns.map(c => {
// For now treat all as strings. In the future, would like to use the
// type info for correct data type mapping
@@ -186,7 +186,7 @@ export class SerializationService implements ISerializationService {
private createContinueRequest(serializationRequest: SerializeDataParams, index: number): azdata.SerializeDataContinueRequestParams {
let numberOfRows = getBatchSize(serializationRequest.rowCount, index);
let rows = serializationRequest.getRowRange(index, serializationRequest.includeHeaders, numberOfRows);
let rows = serializationRequest.getRowRange(index, serializationRequest.includeHeaders ?? false, numberOfRows);
let isLastBatch = index + rows.length >= serializationRequest.rowCount;
let continueSerializeRequest: azdata.SerializeDataContinueRequestParams = {
filePath: serializationRequest.filePath,