ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-08 17:24:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix a bunch of strict issues (#11857)

Browse Source 
* fix a bunch of strict issues

* fix tests

* fix tests
This commit is contained in:
Anthony Dresser
2020-08-19 10:37:30 -07:00
committed by GitHub
parent e90341b3d2
commit 60c62c0668
20 changed files with 100 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/platform/connection/test/common/connectionProfile.test.ts
View File

@@ -187,7 +187,7 @@ suite('SQL ConnectionProfileInfo tests', () => {
});
test('createFromStoredProfile should set the id to new guid if not set in stored profile', () => {
let savedProfile = assign({}, storedProfile, { id: undefined });
let savedProfile: IConnectionProfileStore = assign({}, storedProfile, { id: undefined });
let connectionProfile = ConnectionProfile.createFromStoredProfile(savedProfile, capabilitiesService);
assert.equal(savedProfile.groupId, connectionProfile.groupId);
assert.deepEqual(savedProfile.providerName, connectionProfile.providerName);

16
src/sql/platform/connection/test/common/testConfigurationService.ts
View File

@@ -33,14 +33,16 @@ export class TestConfigurationService implements IConfigurationService {
let _target: 'user' | 'workspace' = (target as ConfigurationTarget) === ConfigurationTarget.USER ? 'user' : 'workspace';
let keyArray = key.split('.');
let targetObject = this.configuration[_target];
for (let i = 0; i < keyArray.length; i++) {
if (i === keyArray.length - 1) {
targetObject[keyArray[i]] = value;
} else {
if (!targetObject[keyArray[i]]) {
targetObject[keyArray[i]] = {};
if (targetObject) {
for (let i = 0; i < keyArray.length; i++) {
if (i === keyArray.length - 1) {
targetObject![keyArray[i]] = value;
} else {
if (!targetObject![keyArray[i]]) {
targetObject![keyArray[i]] = {};
}
targetObject = targetObject![keyArray[i]];
}
targetObject = targetObject[keyArray[i]];
}
}
return Promise.resolve(void 0);

2
src/sql/platform/connection/test/common/testConnectionManagementService.ts
View File

@@ -260,7 +260,7 @@ export class TestConnectionManagementService implements IConnectionManagementSer
}
getConnectionCredentials(profileId: string): Promise<{ [name: string]: string }> {
return Promise.resolve(undefined);
return Promise.resolve(undefined!);
}
getServerInfo(profileId: string): azdata.ServerInfo {