ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adds titles to execution plan widget combo boxes (#20815)

Browse Source 
* Adds titles to execution plan widget combo boxes

* Renames const and title
This commit is contained in:
Lewis Sanchez
2022-10-12 16:03:02 -07:00
committed by GitHub
parent e24068baaa
commit 61fb5db66c
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/sql/workbench/contrib/executionPlan/browser/widgets/highlightExpensiveNodeWidget.ts
View File

@@ -22,6 +22,8 @@ import { searchIconClassNames } from 'sql/workbench/contrib/executionPlan/browse
import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage'; import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage';
const SELECT_EXPENSE_METRIC_TITLE = localize('executionPlanSelectExpenseMetricTitle', 'Select expense metric');
const OFF_STRING = localize('executionPlanOff', 'Off'); const OFF_STRING = localize('executionPlanOff', 'Off');
const ACTUAL_ELAPSED_TIME_STRING = localize('executionPlanActualElapsedTime', 'Actual Elapsed Time'); const ACTUAL_ELAPSED_TIME_STRING = localize('executionPlanActualElapsedTime', 'Actual Elapsed Time');
const ACTUAL_ELAPSED_CPU_TIME_STRING = localize('executionPlanActualElapsedCpuTime', 'Actual Elapsed CPU Time'); const ACTUAL_ELAPSED_CPU_TIME_STRING = localize('executionPlanActualElapsedCpuTime', 'Actual Elapsed CPU Time');
@@ -83,6 +85,7 @@ export class HighlightExpensiveOperationWidget extends ExecutionPlanWidgetBase {
const selectBoxOptions = this.getSelectBoxOptionsFromExecutionPlanDiagram(); const selectBoxOptions = this.getSelectBoxOptionsFromExecutionPlanDiagram();
this.expenseMetricSelectBox = new SelectBox(selectBoxOptions, COST_STRING, this.contextViewService, this._expenseMetricSelectBoxContainer); this.expenseMetricSelectBox = new SelectBox(selectBoxOptions, COST_STRING, this.contextViewService, this._expenseMetricSelectBoxContainer);
this.expenseMetricSelectBox.setAriaLabel(SELECT_EXPENSE_METRIC_TITLE);
this.expenseMetricSelectBox.render(this._expenseMetricSelectBoxContainer); this.expenseMetricSelectBox.render(this._expenseMetricSelectBoxContainer);
this._register(attachSelectBoxStyler(this.expenseMetricSelectBox, this.themeService)); this._register(attachSelectBoxStyler(this.expenseMetricSelectBox, this.themeService));

7
src/sql/workbench/contrib/executionPlan/browser/widgets/nodeSearchWidget.ts
View File

@@ -18,6 +18,10 @@ import { InputBox } from 'sql/base/browser/ui/inputBox/inputBox';
import { AzdataGraphView, SearchType } from 'sql/workbench/contrib/executionPlan/browser/azdataGraphView'; import { AzdataGraphView, SearchType } from 'sql/workbench/contrib/executionPlan/browser/azdataGraphView';
import { ExecutionPlanWidgetController } from 'sql/workbench/contrib/executionPlan/browser/executionPlanWidgetController'; import { ExecutionPlanWidgetController } from 'sql/workbench/contrib/executionPlan/browser/executionPlanWidgetController';
const SELECT_PROPERTY_TITLE = localize('executionPlanSelectPropertyTitle', 'Select property');
const SELECT_SEARCH_TYPE_TITLE = localize('executionPlanSelectSearchTypeTitle', 'Select search type');
const ENTER_SEARCH_VALUE_TITLE = localize('executionPlanEnterValueTitle', 'Enter search value');
const CONTAINS_DISPLAY_STRING = localize("executionPlanSearchTypeContains", 'Contains'); const CONTAINS_DISPLAY_STRING = localize("executionPlanSearchTypeContains", 'Contains');
const EQUALS_DISPLAY_STRING = localize("executionPlanSearchTypeEquals", 'Equals'); const EQUALS_DISPLAY_STRING = localize("executionPlanSearchTypeEquals", 'Equals');
const GREATER_DISPLAY_STRING = '>'; const GREATER_DISPLAY_STRING = '>';
@@ -55,6 +59,7 @@ export class NodeSearchWidget extends ExecutionPlanWidgetBase {
this.container.appendChild(this._propertyNameSelectBoxContainer); this.container.appendChild(this._propertyNameSelectBoxContainer);
const propDropdownOptions = this._executionPlanDiagram.getUniqueElementProperties(); const propDropdownOptions = this._executionPlanDiagram.getUniqueElementProperties();
this._propertyNameSelectBox = new SelectBox(propDropdownOptions, propDropdownOptions[0], this.contextViewService, this._propertyNameSelectBoxContainer); this._propertyNameSelectBox = new SelectBox(propDropdownOptions, propDropdownOptions[0], this.contextViewService, this._propertyNameSelectBoxContainer);
this._propertyNameSelectBox.setAriaLabel(SELECT_PROPERTY_TITLE);
this._register(attachSelectBoxStyler(this._propertyNameSelectBox, this.themeService)); this._register(attachSelectBoxStyler(this._propertyNameSelectBox, this.themeService));
this._propertyNameSelectBoxContainer.style.width = '150px'; this._propertyNameSelectBoxContainer.style.width = '150px';
this._propertyNameSelectBox.render(this._propertyNameSelectBoxContainer); this._propertyNameSelectBox.render(this._propertyNameSelectBoxContainer);
@@ -74,6 +79,7 @@ export class NodeSearchWidget extends ExecutionPlanWidgetBase {
LESSER_EQUAL_DISPLAY_STRING, LESSER_EQUAL_DISPLAY_STRING,
LESSER_AND_GREATER_DISPLAY_STRING LESSER_AND_GREATER_DISPLAY_STRING
], EQUALS_DISPLAY_STRING, this.contextViewService, this._searchTypeSelectBoxContainer); ], EQUALS_DISPLAY_STRING, this.contextViewService, this._searchTypeSelectBoxContainer);
this._searchTypeSelectBox.setAriaLabel(SELECT_SEARCH_TYPE_TITLE);
this._searchTypeSelectBox.render(this._searchTypeSelectBoxContainer); this._searchTypeSelectBox.render(this._searchTypeSelectBoxContainer);
this._register(attachSelectBoxStyler(this._searchTypeSelectBox, this.themeService)); this._register(attachSelectBoxStyler(this._searchTypeSelectBox, this.themeService));
this._searchTypeSelectBoxContainer.style.width = '100px'; this._searchTypeSelectBoxContainer.style.width = '100px';
@@ -105,6 +111,7 @@ export class NodeSearchWidget extends ExecutionPlanWidgetBase {
// search text input box // search text input box
this._searchTextInputBox = new InputBox(this.container, this.contextViewService, {}); this._searchTextInputBox = new InputBox(this.container, this.contextViewService, {});
this._searchTextInputBox.setAriaLabel(ENTER_SEARCH_VALUE_TITLE);
this._register(attachInputBoxStyler(this._searchTextInputBox, this.themeService)); this._register(attachInputBoxStyler(this._searchTextInputBox, this.themeService));
this._searchTextInputBox.element.style.marginLeft = '5px'; this._searchTextInputBox.element.style.marginLeft = '5px';
this._register(this._searchTextInputBox.onDidChange(e => { this._register(this._searchTextInputBox.onDidChange(e => {