ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-21 01:25:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixed #3954 pass connection info to new notebook flow (#4000)

Browse Source 
* Fixed #3954 
The problem is: connectionProfileId is not passed into New Notebook flow.
The fix is: plumbing connectionProfileId via NotebookInput.

* Resolved PR comments
This commit is contained in:
Yurong He
2019-02-11 15:28:05 -08:00
committed by GitHub
parent 6d37329e74
commit 62404721ed
8 changed files with 47 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/sql/platform/connection/common/connectionManagement.ts
View File

@@ -272,6 +272,11 @@ export interface IConnectionManagementService {
* Serialize connection string with optional provider
*/
buildConnectionInfo(connectionString: string, provider?: string): Thenable<sqlops.ConnectionInfo>;
/**
* Get connection profile by id
*/
getConnectionProfileById(profileId: string): IConnectionProfile;
}
export const IConnectionDialogService = createDecorator<IConnectionDialogService>('connectionDialogService');

8
src/sql/platform/connection/common/connectionManagementService.ts
View File

@@ -1378,6 +1378,14 @@ export class ConnectionManagementService extends Disposable implements IConnecti
return serverInfo;
}
public getConnectionProfileById(profileId: string): IConnectionProfile {
let profile = this._connectionStatusManager.findConnectionByProfileId(profileId);
if (!profile) {
return undefined;
}
return profile.connectionProfile;
}
/**
* Get the connection string for the provided connection ID
*/