ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix action dropdowns focusing hidden button & fix ext action button (#21326)

Browse Source
This commit is contained in:
Charles Gagnon
2022-11-29 22:41:48 -08:00
committed by GitHub
parent 23dfd690a6
commit 62d5c1f2d6
3 changed files with 5 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/base/browser/ui/dropdownList/media/dropdownList.css
View File

@@ -3,14 +3,6 @@
* Licensed under the Source EULA. See License.txt in the project root for license information. * Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/ *--------------------------------------------------------------------------------------------*/
.monaco-dropdown {
width: 100%;
/* TODO: Determine a more permanent fix; vs/dropdown is overwriting this selector in packaged builds */
display: flex !important;
align-items: flex-start;
cursor: pointer;
}
.monaco-dropdown > .dropdown-label { .monaco-dropdown > .dropdown-label {
width: 100%; width: 100%;
} }

4
src/vs/base/browser/ui/dropdown/dropdownActionViewItem.ts
View File

@@ -186,6 +186,10 @@ export class ActionWithDropdownActionViewItem extends ActionViewItem {
this.dropdownMenuActionViewItem.render(this.element); this.dropdownMenuActionViewItem.render(this.element);
this._register(addDisposableListener(this.element, EventType.KEY_DOWN, e => { this._register(addDisposableListener(this.element, EventType.KEY_DOWN, e => {
// {{SQL CARBON EDIT}} If we don't have any items then the dropdown is hidden so don't try to focus it #20877
if (menuActionsProvider.getActions().length === 0) {
return;
}
const event = new StandardKeyboardEvent(e); const event = new StandardKeyboardEvent(e);
let handled: boolean = false; let handled: boolean = false;
if (this.dropdownMenuActionViewItem?.isFocused() && event.equals(KeyCode.LeftArrow)) { if (this.dropdownMenuActionViewItem?.isFocused() && event.equals(KeyCode.LeftArrow)) {

6
src/vs/workbench/contrib/extensions/browser/media/extensionsViewlet.css
View File

@@ -56,12 +56,6 @@
display: none; display: none;
} }
/* {{SQL CARBON EDIT}} - hide drop-down to avoid rendering bug */
.extension-editor .details .monaco-action-bar .monaco-dropdown,
.extensions-viewlet > .extensions .monaco-action-bar .monaco-dropdown {
width: 0px;
}
.extensions-viewlet > .extensions .extensions-list.hidden, .extensions-viewlet > .extensions .extensions-list.hidden,
.extensions-viewlet > .extensions .message-container.hidden { .extensions-viewlet > .extensions .message-container.hidden {
display: none; display: none;