Some MSSQL strict null check fixes (#22383)

This commit is contained in:
Charles Gagnon
2023-03-21 16:10:57 -07:00
committed by GitHub
parent 2be49a9911
commit 62ece298cc
7 changed files with 72 additions and 65 deletions

View File

@@ -37,22 +37,17 @@ export default class ContextProvider {
}
public onDashboardOpen(e: azdata.DashboardDocument): void {
let iscloud: boolean;
let edition: number;
let serverMajorVersion: number;
let isCloud: boolean = false;
let edition: number | undefined;
let serverMajorVersion: number | undefined;
if (e.profile.providerName.toLowerCase() === 'mssql' && !types.isUndefinedOrNull(e.serverInfo) && !types.isUndefinedOrNull(e.serverInfo.engineEditionId)) {
if (isCloudEditions.some(i => i === e.serverInfo.engineEditionId)) {
iscloud = true;
} else {
iscloud = false;
}
isCloud = isCloudEditions.some(i => i === e.serverInfo.engineEditionId);
edition = e.serverInfo.engineEditionId;
serverMajorVersion = e.serverInfo.serverMajorVersion;
}
if (iscloud === true || iscloud === false) {
void setCommandContext(ContextKeys.ISCLOUD, iscloud);
if (isCloud === true || isCloud === false) {
void setCommandContext(ContextKeys.ISCLOUD, isCloud);
}
if (!types.isUndefinedOrNull(edition)) {