From 642f5d44051906f5fd7a9a27aade782b9e657f6a Mon Sep 17 00:00:00 2001 From: Anthony Dresser Date: Fri, 12 Apr 2019 13:08:32 -0700 Subject: [PATCH] replace nulls with undefined (#5014) --- .../base/browser/ui/scrollableSplitview/heightMap.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/sql/base/browser/ui/scrollableSplitview/heightMap.ts b/src/sql/base/browser/ui/scrollableSplitview/heightMap.ts index 3e054c93a5..2b3f4ca741 100644 --- a/src/sql/base/browser/ui/scrollableSplitview/heightMap.ts +++ b/src/sql/base/browser/ui/scrollableSplitview/heightMap.ts @@ -31,7 +31,7 @@ export class HeightMap { return !last ? 0 : last.top + last.height; } - public onInsertItems(iterator: INextIterator, afterItemId: string | undefined = undefined): number | undefined { + public onInsertItems(iterator: INextIterator, afterItemId: string | null = null): number | undefined { let viewItem: IViewItem | null = null; let i: number, j: number; let totalSize: number; @@ -91,7 +91,7 @@ export class HeightMap { public onRemoveItems(iterator: INextIterator): void { let itemId: string | null = null; let viewItem: IViewItem; - let startIndex: number | undefined = undefined; + let startIndex: number | null = null; let i = 0; let sizeDiff = 0; @@ -108,12 +108,12 @@ export class HeightMap { delete this.indexes[itemId]; this.onRemoveItem(viewItem); - if (startIndex === undefined) { + if (startIndex === null) { startIndex = i; } } - if (sizeDiff === 0 || startIndex === undefined) { + if (sizeDiff === 0 || startIndex === null) { return; } @@ -201,8 +201,8 @@ export class HeightMap { return this.heightMap[index]; } - public itemAfter(item: IViewItem): IViewItem | undefined { - return this.heightMap[this.indexes[item.view.id!] + 1] || undefined; + public itemAfter(item: IViewItem): IViewItem { + return this.heightMap[this.indexes[item.view.id!] + 1] || null; } public dispose(): void {