ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-21 17:22:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add more folders to strict compile (#8954)

Browse Source 
* add more folders to strictire compile, add more strict compile options

* update ci

* remove unnecessary assertion
This commit is contained in:
Anthony Dresser
2020-01-27 16:26:49 -08:00
committed by GitHub
parent fefe1454de
commit 64929de09d
81 changed files with 630 additions and 644 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/base/browser/ui/table/plugins/additionalKeyBindings.plugin.ts
View File

@@ -10,7 +10,7 @@ import { KeyCode, KeyMod } from 'vs/base/common/keyCodes';
* Implements the various additional navigation keybindings we want out of slickgrid
*/
export class AdditionalKeyBindings<T> implements Slick.Plugin<T> {
private grid: Slick.Grid<T>;
private grid!: Slick.Grid<T>;
private handler = new Slick.EventHandler();
public init(grid: Slick.Grid<T>) {

8
src/sql/base/browser/ui/table/plugins/autoSizeColumns.plugin.ts
View File

@@ -14,10 +14,10 @@ const defaultOptions: IAutoColumnSizeOptions = {
autoSizeOnRender: false
};
export class AutoColumnSize<T extends Object> implements Slick.Plugin<T> {
private _grid: Slick.Grid<T>;
private _$container: JQuery;
private _context: CanvasRenderingContext2D;
export class AutoColumnSize<T extends Slick.SlickData> implements Slick.Plugin<T> {
private _grid!: Slick.Grid<T>;
private _$container!: JQuery;
private _context!: CanvasRenderingContext2D;
private _options: IAutoColumnSizeOptions;
private onPostEventHandler = new Slick.EventHandler();

10
src/sql/base/browser/ui/table/plugins/cellRangeSelector.ts
View File

@@ -37,12 +37,12 @@ export interface ICellRangeDecorator {
}
export class CellRangeSelector<T> implements ICellRangeSelector<T> {
private grid: Slick.Grid<T>;
private dragging: boolean;
private grid!: Slick.Grid<T>;
private dragging?: boolean;
private handler = new Slick.EventHandler();
private decorator: ICellRangeDecorator;
private canvas: HTMLCanvasElement;
private currentlySelectedRange: { start: Slick.Cell, end?: Slick.Cell };
private decorator!: ICellRangeDecorator;
private canvas!: HTMLCanvasElement;
private currentlySelectedRange?: { start: Slick.Cell, end?: Slick.Cell };
public onBeforeCellRangeSelected = new Slick.Event<Slick.Cell>();
public onCellRangeSelected = new Slick.Event<Slick.Range>();

2
src/sql/base/browser/ui/table/plugins/cellSelectionModel.plugin.ts
View File

@@ -16,7 +16,7 @@ const defaults: ICellSelectionModelOptions = {
};
export class CellSelectionModel<T> implements Slick.SelectionModel<T, Array<Slick.Range>> {
private grid: Slick.Grid<T>;
private grid!: Slick.Grid<T>;
private selector: ICellRangeSelector<T>;
private ranges: Array<Slick.Range> = [];
private _handler = new Slick.EventHandler();

6
src/sql/base/browser/ui/table/plugins/checkboxSelectColumn.plugin.ts
View File

@@ -47,10 +47,10 @@ const checkboxTemplate = `<div style="display: flex; align-items: center; flex-d
export class CheckboxSelectColumn<T extends Slick.SlickData> implements Slick.Plugin<T> {
private _options: ICheckboxSelectColumnOptions;
private _grid: Slick.Grid<T>;
private _grid!: Slick.Grid<T>;
private _handler = new Slick.EventHandler();
private _selectedRowsLookup: dict.INumberDictionary<boolean> = {};
private _selectedCheckBoxLookup = {};
private _selectedCheckBoxLookup: {[key: string]: boolean} = {};
private _useState = false;
private _onChange = new Emitter<ICheckboxCellActionEventArgs>();
@@ -274,7 +274,7 @@ export class CheckboxSelectColumn<T extends Slick.SlickData> implements Slick.Pl
// use data for first time rendering
// note: make sure Init is called before using this._grid
let rowVal = (this._grid) ? this._grid.getDataItem(row) : null;
let rowVal = this._grid?.getDataItem(row);
if (rowVal && this._options.title && rowVal[this._options.title] === true) {
this._selectedCheckBoxLookup[row] = true;
return strings.format(checkboxTemplate, 'checked', this.getAriaLabel(true));

2
src/sql/base/browser/ui/table/plugins/copyKeybind.plugin.ts
View File

@@ -12,7 +12,7 @@ import { isUndefinedOrNull } from 'vs/base/common/types';
* Implements the various additional navigation keybindings we want out of slickgrid
*/
export class CopyKeybind<T> implements Slick.Plugin<T> {
private grid: Slick.Grid<T>;
private grid!: Slick.Grid<T>;
private handler = new Slick.EventHandler();
private _onCopy = new Emitter<Slick.Range[]>();

16
src/sql/base/browser/ui/table/plugins/headerFilter.plugin.ts
View File

@@ -19,16 +19,16 @@ export class HeaderFilter<T extends Slick.SlickData> {
public onFilterApplied = new Slick.Event();
public onCommand = new Slick.Event();
private grid: Slick.Grid<T>;
private grid!: Slick.Grid<T>;
private handler = new Slick.EventHandler();
private $menu?: JQuery<HTMLElement>;
private okButton: Button;
private clearButton: Button;
private cancelButton: Button;
private workingFilters: Array<string>;
private columnDef: IExtendedColumn<T>;
private buttonStyles: IButtonStyles;
private okButton?: Button;
private clearButton?: Button;
private cancelButton?: Button;
private workingFilters!: Array<string>;
private columnDef!: IExtendedColumn<T>;
private buttonStyles?: IButtonStyles;
private disposableStore = new DisposableStore();
@@ -286,7 +286,7 @@ export class HeaderFilter<T extends Slick.SlickData> {
if ($checkbox.prop('checked') && index < 0) {
workingFilters.push(filterItems[value]);
const nextRow = filterItems[(parseInt(<string><any>value) + 1).toString()]; // for some reason parseInt is defined as only supporting strings even though it works fine for numbers
const nextRow = filterItems[Number((parseInt(<string><any>value) + 1).toString())]; // for some reason parseInt is defined as only supporting strings even though it works fine for numbers
if (nextRow && nextRow.indexOf('Error:') >= 0) {
workingFilters.push(nextRow);
}

4
src/sql/base/browser/ui/table/plugins/mousewheelTableScroll.plugin.ts
View File

@@ -21,8 +21,8 @@ const defaultOptions: IMouseWheelSupportOptions = {
export class MouseWheelSupport implements Slick.Plugin<any> {
private viewport: HTMLElement;
private canvas: HTMLElement;
private viewport!: HTMLElement;
private canvas!: HTMLElement;
private options: IMouseWheelSupportOptions;
private _disposables = new DisposableStore();

4
src/sql/base/browser/ui/table/plugins/rowDetailView.ts
View File

@@ -51,11 +51,11 @@ export class RowDetailView<T extends Slick.SlickData> {
public readonly onAfterRowDetailToggle = new Slick.Event<{ grid: Slick.Grid<T>, item: T }>();
public readonly onBeforeRowDetailToggle = new Slick.Event<{ grid: Slick.Grid<T>, item: T }>();
private _grid: Slick.Grid<T>;
private _grid!: Slick.Grid<T>;
private _expandedRows: Array<ExtendedItem<T>> = [];
private _handler = new Slick.EventHandler();
private _dataView: AugmentedDataView<T>;
private _dataView!: AugmentedDataView<T>;
private _options: IRowDetailViewOptions<T>;
constructor(options: IRowDetailViewOptions<T>) {

2
src/sql/base/browser/ui/table/plugins/rowNumberColumn.plugin.ts
View File

@@ -10,7 +10,7 @@ export interface IRowNumberColumnOptions {
export class RowNumberColumn<T> implements Slick.Plugin<T> {
private handler = new Slick.EventHandler();
private grid: Slick.Grid<T>;
private grid!: Slick.Grid<T>;
constructor(private options: IRowNumberColumnOptions) {
}

2
src/sql/base/browser/ui/table/plugins/rowSelectionModel.plugin.ts
View File

@@ -12,7 +12,7 @@ export interface IRowSelectionModelOptions extends Slick.PluginOptions {
export class RowSelectionModel<T extends Slick.SlickData> implements Slick.SelectionModel<T, Array<Slick.Range>> {
private _options: IRowSelectionModelOptions;
private _grid: Slick.Grid<T>;
private _grid!: Slick.Grid<T>;
private _handler = new Slick.EventHandler();
private _ranges: Array<Slick.Range> = [];