ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add more folders to strict compile (#8954)

Browse Source 
* add more folders to strictire compile, add more strict compile options

* update ci

* remove unnecessary assertion
This commit is contained in:
Anthony Dresser
2020-01-27 16:26:49 -08:00
committed by GitHub
parent fefe1454de
commit 64929de09d
81 changed files with 630 additions and 644 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/platform/accounts/common/accountActions.ts
View File

@@ -130,7 +130,7 @@ export class ApplyFilterAction extends Action {
export class RefreshAccountAction extends Action {
public static ID = 'account.refresh';
public static LABEL = localize('refreshAccount', "Reenter your credentials");
public account: azdata.Account;
public account?: azdata.Account;
constructor(
@IAccountManagementService private _accountManagementService: IAccountManagementService,

4
src/sql/platform/accounts/common/accountStore.ts
View File

@@ -14,9 +14,9 @@ export default class AccountStore implements IAccountStore {
public static MEMENTO_KEY: string = 'Microsoft.SqlTools.Accounts';
// MEMBER VARIABLES ////////////////////////////////////////////////////
private _activeOperation: Thenable<any>;
private _activeOperation?: Thenable<any>;
constructor(private _memento: object) { }
constructor(private _memento: { [key: string]: any }) { }
// PUBLIC METHODS //////////////////////////////////////////////////////
public addOrUpdate(newAccount: azdata.Account): Thenable<AccountAdditionResult> {

24
src/sql/platform/accounts/common/firewallRuleViewModel.ts
View File

@@ -12,33 +12,33 @@ export class FirewallRuleViewModel {
public isIPAddressSelected: boolean;
public selectedAccount: azdata.Account | undefined;
private _defaultIPAddress: string;
private _defaultFromSubnetIPRange: string;
private _defaultToSubnetIPRange: string;
private _fromSubnetIPRange: string;
private _toSubnetIPRange: string;
private _defaultIPAddress?: string;
private _defaultFromSubnetIPRange?: string;
private _defaultToSubnetIPRange?: string;
private _fromSubnetIPRange?: string;
private _toSubnetIPRange?: string;
constructor() {
this.isIPAddressSelected = true;
}
public get defaultIPAddress(): string {
public get defaultIPAddress(): string | undefined {
return this._defaultIPAddress;
}
public get defaultFromSubnetIPRange(): string {
public get defaultFromSubnetIPRange(): string | undefined {
return this._defaultFromSubnetIPRange;
}
public get defaultToSubnetIPRange(): string {
public get defaultToSubnetIPRange(): string | undefined {
return this._defaultToSubnetIPRange;
}
public set fromSubnetIPRange(IPAddress: string) {
public set fromSubnetIPRange(IPAddress: string | undefined) {
this._fromSubnetIPRange = IPAddress;
}
public get fromSubnetIPRange(): string {
public get fromSubnetIPRange(): string | undefined {
if (this._fromSubnetIPRange) {
return this._fromSubnetIPRange;
} else {
@@ -46,11 +46,11 @@ export class FirewallRuleViewModel {
}
}
public set toSubnetIPRange(IPAddress: string) {
public set toSubnetIPRange(IPAddress: string | undefined) {
this._toSubnetIPRange = IPAddress;
}
public get toSubnetIPRange(): string {
public get toSubnetIPRange(): string | undefined {
if (this._toSubnetIPRange) {
return this._toSubnetIPRange;
} else {