Add more folders to strict compile (#8954)

* add more folders to strictire compile, add more strict compile options

* update ci

* remove unnecessary assertion
This commit is contained in:
Anthony Dresser
2020-01-27 16:26:49 -08:00
committed by GitHub
parent fefe1454de
commit 64929de09d
81 changed files with 630 additions and 644 deletions

View File

@@ -20,15 +20,15 @@ import { IThemeService } from 'vs/platform/theme/common/themeService';
template: ''
})
export class EditableDropDown extends AngularDisposable implements OnInit, OnChanges {
private _selectbox: Dropdown;
private _selectbox!: Dropdown;
@Input() options: string[];
@Input() selectedOption: string;
@Input() options!: string[];
@Input() selectedOption!: string;
@Input() onlyEmitOnChange = false;
@Output() onDidSelect = new EventEmitter<string>();
private _previousVal: string;
private _previousVal?: string;
constructor(
@Inject(forwardRef(() => ElementRef)) private readonly _el: ElementRef,

View File

@@ -20,14 +20,14 @@ import { IContextViewService } from 'vs/platform/contextview/browser/contextView
template: ''
})
export class InputBox extends AngularDisposable implements OnInit, OnChanges {
private _inputbox: vsInputBox;
private _inputbox!: vsInputBox;
@Input() min: string;
@Input() max: string;
@Input() type: string;
@Input() placeholder: string;
@Input('aria-label') ariaLabel: string;
@Input() value: string;
@Input() min?: string;
@Input() max?: string;
@Input() type?: string;
@Input() placeholder?: string;
@Input('aria-label') ariaLabel?: string;
@Input() value?: string;
@Output() onDidChange = new EventEmitter<string | number>();
@@ -67,16 +67,16 @@ export class InputBox extends AngularDisposable implements OnInit, OnChanges {
ngOnChanges(changes: SimpleChanges): void {
if (this._inputbox) {
if (changes['min']) {
this._inputbox.inputElement.min = this.min;
this._inputbox.inputElement.min = this.min!;
}
if (changes['max']) {
this._inputbox.inputElement.max = this.max;
this._inputbox.inputElement.max = this.max!;
}
if (changes['type']) {
this._inputbox.inputElement.type = this.type;
this._inputbox.inputElement.type = this.type!;
}
if (changes['placeholder']) {
this._inputbox.inputElement.placeholder = this.placeholder;
this._inputbox.inputElement.placeholder = this.placeholder!;
}
}
}

View File

@@ -21,16 +21,16 @@ import { IThemeService } from 'vs/platform/theme/common/themeService';
template: ''
})
export class SelectBox extends AngularDisposable implements OnInit, OnChanges {
private _selectbox: vsSelectBox;
private _selectbox!: vsSelectBox;
@Input() options: string[];
@Input() selectedOption: string;
@Input() options!: string[];
@Input() selectedOption!: string;
@Input() onlyEmitOnChange = false;
@Input('aria-label') ariaLabel: string;
@Input('aria-label') ariaLabel?: string;
@Output() onDidSelect = new EventEmitter<ISelectData>();
private _previousVal: string;
private _previousVal?: string;
constructor(
@Inject(forwardRef(() => ElementRef)) private _el: ElementRef,