ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-01 09:35:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add more folders to strict compile (#8954)

Browse Source 
* add more folders to strictire compile, add more strict compile options

* update ci

* remove unnecessary assertion
This commit is contained in:
Anthony Dresser
2020-01-27 16:26:49 -08:00
committed by GitHub
parent fefe1454de
commit 64929de09d
81 changed files with 630 additions and 644 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/workbench/api/common/sqlExtHostTypes.ts
View File

@@ -398,8 +398,8 @@ export enum AzureResource {
export class TreeItem extends vsExtTypes.TreeItem {
label?: string;
payload: IConnectionProfile;
providerHandle: string;
payload?: IConnectionProfile;
providerHandle?: string;
}
export interface ServerInfoOption {

4
src/sql/workbench/contrib/charts/browser/interfaces.ts
View File

@@ -41,8 +41,8 @@ export interface IInsight {
options: IInsightOptions;
data: IInsightData;
readonly types: Array<InsightType | ChartType>;
layout(dim: Dimension);
dispose();
layout(dim: Dimension): void;
dispose(): void;
}
export interface IInsightCtor {

2
src/sql/workbench/contrib/charts/common/interfaces.ts
View File

@@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/
export class ChartState {
dataId: { batchId: number, resultId: number };
dataId?: { batchId: number, resultId: number };
options: IInsightOptions = {
type: ChartType.Bar
};

6
src/sql/workbench/contrib/dashboard/test/electron-browser/propertiesWidget.component.test.ts
View File

@@ -11,7 +11,6 @@ import { WidgetConfig } from 'sql/workbench/contrib/dashboard/browser/core/dashb
import { DashboardServiceInterface } from 'sql/workbench/contrib/dashboard/browser/services/dashboardServiceInterface.service';
import { SingleAdminService, SingleConnectionManagementService } from 'sql/workbench/services/bootstrap/browser/commonServiceInterface.service';
import { PropertiesWidgetComponent } from 'sql/workbench/contrib/dashboard/browser/widgets/properties/propertiesWidget.component';
import { ConnectionManagementInfo } from 'sql/platform/connection/common/connectionManagementInfo';
import * as TypeMoq from 'typemoq';
import * as assert from 'assert';
@@ -88,11 +87,8 @@ suite('Dashboard Properties Widget Tests', () => {
dashboardService.setup(x => x.adminService).returns(() => singleAdminService.object);
let connectionManagementinfo = TypeMoq.Mock.ofType(ConnectionManagementInfo);
connectionManagementinfo.object.serverInfo = serverInfo;
let singleConnectionService = TypeMoq.Mock.ofType(SingleConnectionManagementService);
singleConnectionService.setup(x => x.connectionInfo).returns(() => connectionManagementinfo.object);
singleConnectionService.setup(x => x.connectionInfo).returns(() => ({ serverInfo, providerId: undefined, connectionProfile: undefined, extensionTimer: undefined, serviceTimer: undefined, intelliSenseTimer: undefined, connecting: undefined, ownerUri: undefined }));
dashboardService.setup(x => x.connectionManagementService).returns(() => singleConnectionService.object);

2
src/sql/workbench/contrib/objectExplorer/test/browser/connectionTreeActions.test.ts
View File

@@ -56,7 +56,7 @@ suite('SQL Connection Tree Action tests', () => {
connectionManagementService.callBase = true;
connectionManagementService.setup(x => x.isConnected(undefined, TypeMoq.It.isAny())).returns(() => isConnectedReturnValue);
connectionManagementService.setup(x => x.connect(TypeMoq.It.isAny(), undefined, TypeMoq.It.isAny(), undefined)).returns(() => Promise.resolve(connectionResult));
connectionManagementService.setup(x => x.disconnect(TypeMoq.It.isAny())).returns(() => Promise.resolve(true));
connectionManagementService.setup(x => x.disconnect(TypeMoq.It.isAny())).returns(() => Promise.resolve());
connectionManagementService.setup(x => x.findExistingConnection(TypeMoq.It.isAny())).returns(() => undefined);
connectionManagementService.setup(x => x.showDashboard(TypeMoq.It.isAny())).returns(() => Promise.resolve(true));
connectionManagementService.setup(x => x.isProfileConnected(TypeMoq.It.isAny())).returns(() => isConnectedReturnValue);

8
src/sql/workbench/services/fileBrowser/common/fileBrowserTree.ts
View File

@@ -8,8 +8,8 @@ import { FileNode } from 'sql/workbench/services/fileBrowser/common/fileNode';
/**
* File tree info needed to render initially
*/
export class FileBrowserTree {
public rootNode: FileNode;
public selectedNode?: FileNode;
public expandedNodes: FileNode[];
export interface FileBrowserTree {
rootNode: FileNode;
selectedNode?: FileNode;
expandedNodes: FileNode[];
}

4
src/sql/workbench/services/fileBrowser/common/fileNode.ts
View File

@@ -38,7 +38,7 @@ export class FileNode {
/**
* Children nodes
*/
public children: FileNode[];
public children?: FileNode[];
/**
* Is the node expanded
@@ -53,7 +53,7 @@ export class FileNode {
/**
* Does this node have children
*/
public hasChildren: boolean;
public hasChildren?: boolean;
constructor(id: string, name: string, fullPath: string, isFile: boolean, isExpanded: boolean, ownerUri: string, parent?: FileNode) {
if (id) {