Fix preview handling so the untitled notebooks are pinned by default (#3405)

src/sql/workbench/api/node/extHostNotebookDocumentsAndEditors.ts

@@ -237,6 +237,7 @@ export class ExtHostNotebookDocumentsAndEditors implements ExtHostNotebookDocume
 		let options: INotebookShowOptions = {};
 		if (showOptions) {
 			options.preserveFocus = showOptions.preserveFocus;
+			options.preview = showOptions.preview;
 			options.position = showOptions.viewColumn;
 			options.providerId = showOptions.providerId;
 			options.connectionId = showOptions.connectionId;

src/sql/workbench/api/node/mainThreadNotebookDocumentsAndEditors.ts

@@ -257,7 +257,7 @@ export class MainThreadNotebookDocumentsAndEditors extends Disposable implements
 
 		const editorOptions: ITextEditorOptions = {
 			preserveFocus: options.preserveFocus,
-			pinned: options.pinned
+			pinned: !options.preview
 		};
 		let model = new NotebookInputModel(uri, undefined, false, undefined);
 		let providerId = options.providerId;

src/sql/workbench/api/node/sqlExtHost.protocol.ts

@@ -807,7 +807,7 @@ export interface INotebookEditorAddData {
 export interface INotebookShowOptions {
 	position?: EditorViewColumn;
 	preserveFocus?: boolean;
-	pinned?: boolean;
+	preview?: boolean;
 	providerId?: string;
 	connectionId?: string;
 }