ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

make the toolbar items keyboard focusable (#16017)

Browse Source 
* make the toolbar items keyboard focusable

* add comment
This commit is contained in:
Alan Ren
2021-07-07 13:45:07 -07:00
committed by GitHub
parent d942799f9d
commit 64cee64516
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/sql/base/browser/ui/taskbar/actionbar.ts
View File

@@ -238,6 +238,13 @@ export class ActionBar extends ActionRunner implements IActionRunner {
//this.addEmitter(item); //this.addEmitter(item);
item.render(actionItemElement); item.render(actionItemElement);
// VSCode toolbar now will only receive one tab stop, by default all items are not focusable.
// Adding the following change to make sure the ADS toolbars are keyboard focusable to match the previous behavior as a temporary solution.
// TODO: https://github.com/microsoft/azuredatastudio/issues/16016
if (item instanceof BaseActionViewItem) {
item.setFocusable(true);
}
if (index === null || index < 0 || index >= this._actionsList.children.length) { if (index === null || index < 0 || index >= this._actionsList.children.length) {
this._actionsList.appendChild(actionItemElement); this._actionsList.appendChild(actionItemElement);
} else { } else {