ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix several dashboard issues and add telemetry (#889)

Browse Source 
* fix several dashboard issues

* formatting

* address comments

* keep track of number of page navigation inside the dashboard service
This commit is contained in:
Abbie Petchtes
2018-03-12 13:16:20 -07:00
committed by GitHub
parent 5c0002404a
commit 64f61b2954
6 changed files with 67 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/sql/parts/dashboard/common/dashboardTab.contribution.ts
View File

@@ -5,6 +5,7 @@
import { IExtensionPointUser, ExtensionsRegistry } from 'vs/platform/extensions/common/extensionsRegistry';
import { IJSONSchema } from 'vs/base/common/jsonSchema';
import { localize } from 'vs/nls';
import * as types from 'vs/base/common/types';
import { registerTab } from 'sql/platform/dashboard/common/dashboardRegistry';
import { generateContainerTypeSchemaProperties } from 'sql/platform/dashboard/common/dashboardContainerRegistry';
@@ -92,7 +93,11 @@ ExtensionsRegistry.registerExtensionPoint<IDashboardTabContrib | IDashboardTabCo
function handleCommand(tab: IDashboardTabContrib, extension: IExtensionPointUser<any>) {
let { description, container, title, edition, provider, id, alwaysShow } = tab;
alwaysShow = alwaysShow || false;
// If always show is not specified, set it to true by default.
if (!types.isBoolean(alwaysShow)) {
alwaysShow = true;
}
let publisher = extension.description.publisher;
if (!title) {
extension.collector.error(localize('dashboardTab.contribution.noTitleError', 'No title specified for extension.'));