Merge from vscode 0f73473c08055054f317c1c94502f7f39fdbb164 (#6892)

* Merge from vscode 0f73473c08055054f317c1c94502f7f39fdbb164

* fix tslinting

build/azure-pipelines/distro-build.yml

@@ -1,3 +1,6 @@
+pool:
+  vmImage: 'Ubuntu-16.04'
+
 trigger:
   branches:
     include: ['master', 'release/*']

build/azure-pipelines/exploration-build.yml

@@ -1,3 +1,6 @@
+pool:
+  vmImage: 'Ubuntu-16.04'
+
 trigger:
   branches:
     include: ['master']
@@ -10,20 +13,10 @@ steps:
   inputs:
     versionSpec: "10.15.1"
 
-- task: AzureKeyVault@1
-  displayName: 'Azure Key Vault: Get Secrets'
-  inputs:
-    azureSubscription: 'vscode-builds-subscription'
-    KeyVaultName: vscode
-
 - script: |
     set -e
 
     cat << EOF > ~/.netrc
-    machine github.com
-    login vscode
-    password $(github-distro-mixin-password)
-    EOF
 
     git config user.email "vscode@microsoft.com"
     git config user.name "VSCode"

build/azure-pipelines/product-build.yml

@@ -143,8 +143,8 @@ trigger: none
 pr: none
 
 schedules:
-- cron: "0 5 * * Mon-Fri"
-  displayName: Mon-Fri at 7:00
+- cron: "10 5 * * Mon-Fri"
+  displayName: Mon-Fri at 7:10
   branches:
     include:
     - master

build/gulpfile.hygiene.js

@@ -252,7 +252,7 @@ gulp.task('tslint', () => {
 			.pipe(filter(tslintExtensionsFilter))
 			.pipe(gulptslint.default({ rulesDirectory: 'build/lib/tslint' }))
 			.pipe(gulptslint.default.report({ emitError: true }))
-	]).pipe(es.through()); // {{SQL CARBON EDIT}} fix issue
+	]).pipe(es.through());
 });
 
 function hygiene(some) {

build/lib/tslint/noNodejsGlobalsRule.js

@@ -26,6 +26,7 @@ class NoNodejsGlobalsRuleWalker extends abstractGlobalsRule_1.AbstractGlobalsRul
     getDisallowedGlobals() {
         // https://nodejs.org/api/globals.html#globals_global_objects
         return [
+            "NodeJS",
             "Buffer",
             "__dirname",
             "__filename",

build/lib/tslint/noNodejsGlobalsRule.ts

@@ -37,6 +37,7 @@ class NoNodejsGlobalsRuleWalker extends AbstractGlobalsRuleWalker {
 	getDisallowedGlobals(): string[] {
 		// https://nodejs.org/api/globals.html#globals_global_objects
 		return [
+			"NodeJS",
 			"Buffer",
 			"__dirname",
 			"__filename",