ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix notebook results grid settings not updating (#11413)

Browse Source 
* added boolean for results grid settings changed

* change parameter name to forceThemeUpdate
This commit is contained in:
Lucy Zhang
2020-07-20 10:28:27 -07:00
committed by GitHub
parent decba446dd
commit 66632e6262
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/sql/workbench/contrib/notebook/browser/notebookThemingContribution.ts
View File

@@ -20,19 +20,20 @@ export class NotebookThemingContribution extends Disposable implements IWorkbenc
private hookNotebookThemesAndConfigListener(): void { private hookNotebookThemesAndConfigListener(): void {
if (this.configurationService) { if (this.configurationService) {
this.updateNotebookThemes(); this.updateNotebookThemes(false);
this._register(this.configurationService.onDidChangeConfiguration(e => { this._register(this.configurationService.onDidChangeConfiguration(e => {
let affectsResultsGrid = e.affectsConfiguration('resultsGrid');
if (e.affectsConfiguration(OVERRIDE_EDITOR_THEMING_SETTING) if (e.affectsConfiguration(OVERRIDE_EDITOR_THEMING_SETTING)
|| e.affectsConfiguration('resultsGrid')) { || affectsResultsGrid) {
this.updateNotebookThemes(); this.updateNotebookThemes(affectsResultsGrid);
} }
})); }));
} }
} }
private updateNotebookThemes() { private updateNotebookThemes(forceThemeUpdate: boolean) {
let overrideEditorSetting = this.configurationService.getValue<boolean>(OVERRIDE_EDITOR_THEMING_SETTING); let overrideEditorSetting = this.configurationService.getValue<boolean>(OVERRIDE_EDITOR_THEMING_SETTING);
if (overrideEditorSetting !== this.overrideEditorThemeSetting) { if (overrideEditorSetting !== this.overrideEditorThemeSetting || forceThemeUpdate) {
// Re-add the participant since this will trigger update of theming rules, can't just // Re-add the participant since this will trigger update of theming rules, can't just
// update something and ask to change // update something and ask to change
if (this.themeParticipant) { if (this.themeParticipant) {