Fix accessibility bugs in Chart Viewer and Advanced properties (#2240)

* fix accessibility bugs in chart viewer

* add advanced properties

* add comments for changes in vs
This commit is contained in:
Anthony Dresser
2018-08-20 16:19:29 -07:00
committed by GitHub
parent 08a8288293
commit 6668ec4b5d
9 changed files with 45 additions and 20 deletions

View File

@@ -28,6 +28,7 @@ export class SelectBox extends AngularDisposable implements OnInit, OnChanges {
@Input() options: string[];
@Input() selectedOption: string;
@Input() onlyEmitOnChange = false;
@Input('aria-label') ariaLabel: string;
@Output() onDidSelect = new EventEmitter<ISelectData>();
@@ -42,7 +43,7 @@ export class SelectBox extends AngularDisposable implements OnInit, OnChanges {
}
ngOnInit(): void {
this._selectbox = new vsSelectBox(this.options, this.selectedOption, this.contextViewService);
this._selectbox = new vsSelectBox(this.options, this.selectedOption, this.contextViewService, undefined, { ariaLabel: this.ariaLabel });
this._selectbox.render(this._el.nativeElement);
this._selectbox.onDidSelect(e => {
if (this.onlyEmitOnChange) {