Fix accessibility bugs in Chart Viewer and Advanced properties (#2240)

* fix accessibility bugs in chart viewer

* add advanced properties

* add comments for changes in vs
This commit is contained in:
Anthony Dresser
2018-08-20 16:19:29 -07:00
committed by GitHub
parent 08a8288293
commit 6668ec4b5d
9 changed files with 45 additions and 20 deletions

View File

@@ -35,6 +35,8 @@ export interface ISelectBoxDelegate {
}
export interface ISelectBoxOptions {
// {{SQL CARBON EDIT}}
ariaLabel?: string;
minBottomMargin?: number;
}
@@ -76,7 +78,8 @@ export class SelectBox extends Widget implements ISelectBoxDelegate {
// Instantiate select implementation based on platform
if (isMacintosh) {
this.selectBoxDelegate = new SelectBoxNative(options, selected, styles);
// {{SQL CARBON EDIT}}
this.selectBoxDelegate = new SelectBoxNative(options, selected, styles, selectBoxOptions);
} else {
this.selectBoxDelegate = new SelectBoxList(options, selected, contextViewProvider, styles, selectBoxOptions);
}