ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-17 09:35:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix sql projects net6 warnings (#17673)

Browse Source 
* fix .net 6 error showing on startup

* fix double warning

* addressing comments

* update key string
This commit is contained in:
Kim Santiago
2021-11-16 10:02:15 -10:00
committed by GitHub
parent 1b83c4623d
commit 66c438db4d
5 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/sql-database-projects/src/controllers/mainController.ts
View File

@@ -82,9 +82,6 @@ export default class MainController implements vscode.Disposable {
IconPathHelper.setExtensionContext(this.extensionContext);
await templates.loadTemplates(path.join(this.context.extensionPath, 'resources', 'templates'));
// ensure .net core is installed
await this.netcoreTool.findOrInstallNetCore();
}
public dispose(): void {

3
extensions/sql-database-projects/src/controllers/projectController.ts
View File

@@ -252,7 +252,8 @@ export class ProjectsController {
const message = utils.getErrorMessage(err);
if (err instanceof DotNetError) {
void vscode.window.showErrorMessage(message);
// DotNetErrors already get shown by the netCoreTool so just show this one in the console
console.error(message);
} else {
void vscode.window.showErrorMessage(constants.projBuildFailed(message));
}

2
extensions/sql-database-projects/src/tools/netcoreTool.ts
View File

@@ -17,7 +17,7 @@ import { ShellCommandOptions, ShellExecutionHelper } from './shellExecutionHelpe
const localize = nls.loadMessageBundle();
export const DBProjectConfigurationKey: string = 'sqlDatabaseProjects';
export const NetCoreInstallLocationKey: string = 'netCoreSDKLocation';
export const NetCoreInstallLocationKey: string = 'netCoreSDK Location';
export const NetCoreDoNotAskAgainKey: string = 'netCoreDoNotAsk';
export const NetCoreDowngradeDoNotShowAgainKey: string = 'netCoreDowngradeDoNotShow';
export const NetCoreNonWindowsDefaultPath = '/usr/local/share';