Making better ep highlights (#20055)

This commit is contained in:
Aasim Khan
2022-07-15 15:31:01 -07:00
committed by GitHub
parent 023ee57e98
commit 67637a41f5
8 changed files with 13 additions and 16 deletions

View File

@@ -76,7 +76,7 @@
"angular2-grid": "2.0.6",
"ansi_up": "^5.1.0",
"applicationinsights": "1.0.8",
"azdataGraph": "github:Microsoft/azdataGraph#0.0.33",
"azdataGraph": "github:Microsoft/azdataGraph#0.0.36",
"chart.js": "^2.9.4",
"chokidar": "3.5.1",
"graceful-fs": "4.2.8",

View File

@@ -17,7 +17,7 @@
"applicationinsights": "1.0.8",
"angular2-grid": "2.0.6",
"ansi_up": "^5.1.0",
"azdataGraph": "github:Microsoft/azdataGraph#0.0.33",
"azdataGraph": "github:Microsoft/azdataGraph#0.0.36",
"chart.js": "^2.9.4",
"cookie": "^0.4.0",
"graceful-fs": "4.2.8",

View File

@@ -15,7 +15,7 @@
"@vscode/vscode-languagedetection": "1.0.21",
"angular2-grid": "2.0.6",
"ansi_up": "^5.1.0",
"azdataGraph": "github:Microsoft/azdataGraph#0.0.33",
"azdataGraph": "github:Microsoft/azdataGraph#0.0.36",
"chart.js": "^2.9.4",
"gridstack": "^3.1.3",
"kburtram-query-plan": "2.6.1",

View File

@@ -150,9 +150,9 @@ array-uniq@^1.0.2:
resolved "https://registry.yarnpkg.com/array-uniq/-/array-uniq-1.0.3.tgz#af6ac877a25cc7f74e058894753858dfdb24fdb6"
integrity sha1-r2rId6Jcx/dOBYiUdThY39sk/bY=
"azdataGraph@github:Microsoft/azdataGraph#0.0.33":
version "0.0.33"
resolved "https://codeload.github.com/Microsoft/azdataGraph/tar.gz/03b12598831a85f977f5e58f22cbd7ff37e16b04"
"azdataGraph@github:Microsoft/azdataGraph#0.0.36":
version "0.0.36"
resolved "https://codeload.github.com/Microsoft/azdataGraph/tar.gz/f93a93d5269ebb3768cc75ccb19f2085957f7eb2"
chalk@^2.3.0, chalk@^2.4.1:
version "2.4.2"

View File

@@ -198,9 +198,9 @@ array-uniq@^1.0.2:
resolved "https://registry.yarnpkg.com/array-uniq/-/array-uniq-1.0.3.tgz#af6ac877a25cc7f74e058894753858dfdb24fdb6"
integrity sha1-r2rId6Jcx/dOBYiUdThY39sk/bY=
"azdataGraph@github:Microsoft/azdataGraph#0.0.33":
version "0.0.33"
resolved "https://codeload.github.com/Microsoft/azdataGraph/tar.gz/03b12598831a85f977f5e58f22cbd7ff37e16b04"
"azdataGraph@github:Microsoft/azdataGraph#0.0.36":
version "0.0.36"
resolved "https://codeload.github.com/Microsoft/azdataGraph/tar.gz/f93a93d5269ebb3768cc75ccb19f2085957f7eb2"
bindings@^1.5.0:
version "1.5.0"

View File

@@ -49,7 +49,6 @@ export class AzdataGraphView {
this._diagram = new azdataGraph.azdataQueryPlan(queryPlanConfiguration);
this.setGraphProperties();
this.selectElement(this._executionPlan.root);
this._cellInFocus = this._diagram.graph.getSelectionCell();
this.initializeGraphEvents();
}
@@ -72,7 +71,7 @@ export class AzdataGraphView {
this.onElementSelected = this._onElementSelectedEmitter.event;
this._diagram.graph.getSelectionModel().addListener('change', (sender, evt) => {
if (evt.properties?.removed) {
if (this._cellInFocus.id === evt.properties.removed[0].id) {
if (this._cellInFocus?.id === evt.properties.removed[0].id) {
return;
}
const newSelection = evt.properties.removed[0];

View File

@@ -193,7 +193,6 @@ export class ExecutionPlanComparisonEditorView {
c.style.display = 'none';
});
this._topPlanDiagramContainers[e.index].style.display = '';
this.topPlanDiagrams[e.index].selectElement(undefined);
this._propertiesView.setTopElement(this._topPlanDiagramModels[e.index].root);
this._topPlanRecommendations.recommendations = this._topPlanDiagramModels[e.index].recommendations;
this._activeTopPlanIndex = e.index;
@@ -221,7 +220,6 @@ export class ExecutionPlanComparisonEditorView {
c.style.display = 'none';
});
this._bottomPlanDiagramContainers[e.index].style.display = '';
this.bottomPlanDiagrams[e.index].selectElement(undefined);
this._propertiesView.setTopElement(this._bottomPlanDiagramModels[e.index].root);
this._bottomPlanRecommendations.recommendations = this._bottomPlanDiagramModels[e.index].recommendations;
this._activeBottomPlanIndex = e.index;

View File

@@ -1891,9 +1891,9 @@ aws4@^1.8.0:
resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.8.0.tgz#f0e003d9ca9e7f59c7a508945d7b2ef9a04a542f"
integrity sha512-ReZxvNHIOv88FlT7rxcXIIC0fPt4KZqZbOlivyWtXLt8ESx84zd3kMC6iK5jVeS2qt+g7ftS7ye4fi06X5rtRQ==
"azdataGraph@github:Microsoft/azdataGraph#0.0.33":
version "0.0.33"
resolved "https://codeload.github.com/Microsoft/azdataGraph/tar.gz/03b12598831a85f977f5e58f22cbd7ff37e16b04"
"azdataGraph@github:Microsoft/azdataGraph#0.0.36":
version "0.0.36"
resolved "https://codeload.github.com/Microsoft/azdataGraph/tar.gz/f93a93d5269ebb3768cc75ccb19f2085957f7eb2"
bach@^1.0.0:
version "1.2.0"