Callout Dialog Fixes + WYSIWYG Improvements for Insert Link (#14494)

* wip

* Works in all edit modes

* Default value set

* wip

* preventdefault

* cleanup, add tests

* markup -> markdown

* Ensure selection is persisted for WYSIWYG

* Add simple dialog tests and some PR feedback

* floating promise

* PR comments, formatted markdown refactor

* Change escaping logic + PR comments

* PR feedback

src/sql/workbench/contrib/notebook/test/calloutDialog/linkCalloutDialog.test.ts

@@ -0,0 +1,106 @@
+import * as assert from 'assert';
+
+import { ILinkCalloutDialogOptions, LinkCalloutDialog } from 'sql/workbench/contrib/notebook/browser/calloutDialog/linkCalloutDialog';
+import { TestLayoutService } from 'vs/workbench/test/browser/workbenchTestServices';
+import { ILayoutService } from 'vs/platform/layout/browser/layoutService';
+import { IThemeService } from 'vs/platform/theme/common/themeService';
+import { TestThemeService } from 'vs/platform/theme/test/common/testThemeService';
+import { NullAdsTelemetryService } from 'sql/platform/telemetry/common/adsTelemetryService';
+import { IAdsTelemetryService } from 'sql/platform/telemetry/common/telemetry';
+import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
+import { MockContextKeyService } from 'vs/platform/keybinding/test/common/mockKeybindingService';
+import { Deferred } from 'sql/base/common/promise';
+import { escapeLabel, escapeUrl } from 'sql/workbench/contrib/notebook/browser/calloutDialog/common/utils';
+
+suite('Link Callout Dialog', function (): void {
+	let layoutService: ILayoutService;
+	let themeService: IThemeService;
+	let telemetryService: IAdsTelemetryService;
+	let contextKeyService: IContextKeyService;
+
+	setup(() => {
+		layoutService = new TestLayoutService();
+		themeService = new TestThemeService();
+		telemetryService = new NullAdsTelemetryService();
+		contextKeyService = new MockContextKeyService();
+	});
+
+	test('Should return empty markdown on cancel', async function (): Promise<void> {
+		let linkCalloutDialog = new LinkCalloutDialog('Title', undefined, 'defaultLabel',
+			undefined, themeService, layoutService, telemetryService, contextKeyService, undefined, undefined, undefined);
+		linkCalloutDialog.render();
+
+		let deferred = new Deferred<ILinkCalloutDialogOptions>();
+		// When I first open the callout dialog
+		linkCalloutDialog.open().then(value => {
+			deferred.resolve(value);
+		});
+		// And cancel the dialog
+		linkCalloutDialog.cancel();
+		let result = await deferred.promise;
+
+		assert.equal(result.insertUnescapedLinkLabel, 'defaultLabel', 'Label not returned correctly');
+		assert.equal(result.insertUnescapedLinkUrl, undefined, 'URL not returned correctly');
+		assert.equal(result.insertEscapedMarkdown, '', 'Markdown not returned correctly');
+	});
+
+	test('Should return expected values on insert', async function (): Promise<void> {
+		const defaultLabel = 'defaultLabel';
+		const sampleUrl = 'https://www.aka.ms/azuredatastudio';
+		let linkCalloutDialog = new LinkCalloutDialog('Title', undefined, defaultLabel,
+			undefined, themeService, layoutService, telemetryService, contextKeyService, undefined, undefined, undefined);
+		linkCalloutDialog.render();
+
+		let deferred = new Deferred<ILinkCalloutDialogOptions>();
+		// When I first open the callout dialog
+		linkCalloutDialog.open().then(value => {
+			deferred.resolve(value);
+		});
+
+		linkCalloutDialog.url = sampleUrl;
+
+		// And insert the dialog
+		linkCalloutDialog.insert();
+		let result = await deferred.promise;
+		assert.equal(result.insertUnescapedLinkLabel, defaultLabel, 'Label not returned correctly');
+		assert.equal(result.insertUnescapedLinkUrl, sampleUrl, 'URL not returned correctly');
+		assert.equal(result.insertEscapedMarkdown, `[${defaultLabel}](${sampleUrl})`, 'Markdown not returned correctly');
+	});
+
+	test('Should return expected values on insert when escape necessary', async function (): Promise<void> {
+		const defaultLabel = 'default[]Label';
+		const sampleUrl = 'https://www.aka.ms/azuredatastudio()';
+		let linkCalloutDialog = new LinkCalloutDialog('Title', undefined, defaultLabel,
+			undefined, themeService, layoutService, telemetryService, contextKeyService, undefined, undefined, undefined);
+		linkCalloutDialog.render();
+
+		let deferred = new Deferred<ILinkCalloutDialogOptions>();
+		// When I first open the callout dialog
+		linkCalloutDialog.open().then(value => {
+			deferred.resolve(value);
+		});
+
+		linkCalloutDialog.url = sampleUrl;
+
+		// And insert the dialog
+		linkCalloutDialog.insert();
+		let result = await deferred.promise;
+		assert.equal(result.insertUnescapedLinkLabel, defaultLabel, 'Label not returned correctly');
+		assert.equal(result.insertUnescapedLinkUrl, sampleUrl, 'URL not returned correctly');
+		assert.equal(result.insertEscapedMarkdown, '[default\[\]Label](https://www.aka.ms/azuredatastudio%28%29)', 'Markdown not returned correctly');
+	});
+
+	test('Label escape', function (): void {
+		assert.equal(escapeLabel('TestLabel'), 'TestLabel', 'Basic escape label test failed');
+		assert.equal(escapeLabel('Test[]Label'), 'Test\[\]Label', 'Label test square brackets failed');
+		assert.equal(escapeLabel('<>&[]'), '&lt;&gt;&amp;\[\]', 'Label test known escaped characters failed');
+		assert.equal(escapeLabel('<>&[]()'), '&lt;&gt;&amp;\[\]()', 'Label test all escaped characters failed');
+	});
+
+	test('URL escape', function (): void {
+		assert.equal(escapeUrl('TestURL'), 'TestURL', 'Basic escape URL test failed');
+		assert.equal(escapeUrl('Test()URL'), 'Test%28%29URL', 'URL test square brackets failed');
+		assert.equal(escapeUrl('<>&()'), '&lt;&gt;&amp;%28%29', 'URL test known escaped characters failed');
+		assert.equal(escapeUrl('<>&()[]'), '&lt;&gt;&amp;%28%29[]', 'URL test all escaped characters failed');
+	});
+});