ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adding back save api (#4407)

Browse Source 
* #4339: Kernel change event occurs after model load

* #4347: Code cleanup - Notebooks Save

* Remove save method from sqlops

* Adding save method to api's

* Adding save method to ext host

* Misc change
This commit is contained in:
Raj
2019-03-12 13:07:10 -07:00
committed by GitHub
parent 2db83b3892
commit 6a7df2f1ae
10 changed files with 5 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sql/parts/notebook/models/modelInterfaces.ts
View File

@@ -370,12 +370,6 @@ export interface INotebookModel {
*/
deleteCell(cellModel: ICellModel): void;
/**
* Save the model to its backing content manager.
* Serializes the model and then calls through to save it
*/
saveModel(): Promise<boolean>;
/**
* Serialize notebook cell content to JSON
*/

14
src/sql/parts/notebook/models/notebookModel.ts
View File

@@ -766,20 +766,6 @@ export class NotebookModel extends Disposable implements INotebookModel {
return name;
}
public async saveModel(): Promise<boolean> {
let notebook = this.toJSON();
if (!notebook) {
return false;
}
// TODO: refactor ContentManager out from NotebookManager
await this.notebookManagers[0].contentManager.save(this._notebookOptions.notebookUri, notebook);
this._contentChangedEmitter.fire({
changeType: NotebookChangeType.DirtyStateChanged,
isDirty: false
});
return true;
}
private async updateKernelInfo(kernel: nb.IKernel): Promise<void> {
if (kernel) {
try {