ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary awaits from extensions (#19571)

Browse Source 
* Remove unnecessary awaits

* fix ignore

* revert eslintignore

* try

* increase size

* Increase sql lint size
This commit is contained in:
Charles Gagnon
2022-05-31 15:36:44 -07:00
committed by GitHub
parent 96f345a74a
commit 6ae380b65d
65 changed files with 179 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/sql-assessment/.eslintrc.json
View File

@@ -1,4 +1,7 @@
{
"parserOptions": {
"project": "./extensions/sql-assessment/tsconfig.json"
},
"rules": {
// Disabled until the issues can be fixed
"@typescript-eslint/explicit-function-return-type": ["off"]

8
extensions/sql-assessment/src/engine.ts
View File

@@ -65,7 +65,7 @@ export class AssessmentEngine {
} else {
if (asmtType === AssessmentType.AvailableRules) {
TelemetryReporter.sendActionEvent(SqlAssessmentTelemetryView, SqlTelemetryActions.GetDatabaseAssessmentRules);
await onResult(await this.sqlAssessment.getAssessmentItems(this.connectionUri, azdata.sqlAssessment.SqlAssessmentTargetType.Database), asmtType, false);
onResult(await this.sqlAssessment.getAssessmentItems(this.connectionUri, azdata.sqlAssessment.SqlAssessmentTargetType.Database), asmtType, false);
} else {
TelemetryReporter.sendActionEvent(SqlAssessmentTelemetryView, SqlTelemetryActions.InvokeDatabaseAssessment);
const result = await this.sqlAssessment.assessmentInvoke(this.connectionUri, azdata.sqlAssessment.SqlAssessmentTargetType.Database);
@@ -76,7 +76,7 @@ export class AssessmentEngine {
result: result
};
await onResult(result, asmtType, false);
onResult(result, asmtType, false);
this.saveAssessment(this.databaseName, result);
}
@@ -147,7 +147,7 @@ export class AssessmentEngine {
assessmentResult = await this.sqlAssessment.getAssessmentItems(this.connectionUri, azdata.sqlAssessment.SqlAssessmentTargetType.Server);
}
await onResult(assessmentResult, asmtType, false);
onResult(assessmentResult, asmtType, false);
let connectionProvider = azdata.dataprotocol.getProvider<azdata.ConnectionProvider>(
this.connectionProfile.providerId, azdata.DataProviderType.ConnectionProvider);
@@ -167,7 +167,7 @@ export class AssessmentEngine {
this.lastInvokedResults.result.items.push(...assessmentResult?.items);
this.saveAssessment(db, assessmentResult);
}
await onResult(assessmentResult, asmtType, true);
onResult(assessmentResult, asmtType, true);
}
}
}