From 6b189be7817cbbe8aec71f8a03fc6ba507f7f664 Mon Sep 17 00:00:00 2001 From: Kim Santiago <31145923+kisantia@users.noreply.github.com> Date: Wed, 19 May 2021 11:03:53 -0700 Subject: [PATCH] update comments and name for clarity (#15504) --- extensions/data-workspace/src/dataworkspace.d.ts | 2 +- extensions/data-workspace/src/dialogs/projectDashboard.ts | 2 +- .../data-workspace/src/test/projectProviderRegistry.test.ts | 2 +- .../data-workspace/src/test/workspaceTreeDataProvider.test.ts | 2 +- .../src/projectProvider/projectProvider.ts | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/extensions/data-workspace/src/dataworkspace.d.ts b/extensions/data-workspace/src/dataworkspace.d.ts index 3fd9420fcc..1fa01e073e 100644 --- a/extensions/data-workspace/src/dataworkspace.d.ts +++ b/extensions/data-workspace/src/dataworkspace.d.ts @@ -80,7 +80,7 @@ declare module 'dataworkspace' { /** * Gets the project actions to be placed on the dashboard toolbar */ - readonly projectActions: (IProjectAction | IProjectActionGroup)[]; + readonly projectToolbarActions: (IProjectAction | IProjectActionGroup)[]; /** * Gets the project image to be used as background in dashboard container diff --git a/extensions/data-workspace/src/dialogs/projectDashboard.ts b/extensions/data-workspace/src/dialogs/projectDashboard.ts index 90cef6772e..05b1572897 100644 --- a/extensions/data-workspace/src/dialogs/projectDashboard.ts +++ b/extensions/data-workspace/src/dialogs/projectDashboard.ts @@ -62,7 +62,7 @@ export class ProjectDashboard { } private createToolbarContainer(projectFilePath: string): azdata.ToolbarContainer { - const projectActions: (IProjectAction | IProjectActionGroup)[] = this.projectProvider!.projectActions; + const projectActions: (IProjectAction | IProjectActionGroup)[] = this.projectProvider!.projectToolbarActions; // Add actions as buttons const buttons: azdata.ToolbarComponent[] = []; diff --git a/extensions/data-workspace/src/test/projectProviderRegistry.test.ts b/extensions/data-workspace/src/test/projectProviderRegistry.test.ts index c7d447d8ec..a311abbcc4 100644 --- a/extensions/data-workspace/src/test/projectProviderRegistry.test.ts +++ b/extensions/data-workspace/src/test/projectProviderRegistry.test.ts @@ -32,7 +32,7 @@ export function createProjectProvider(projectTypes: IProjectType[], projectActio createProject: (name: string, location: vscode.Uri, projectTypeId: string): Promise => { return Promise.resolve(location); }, - projectActions: projectActions, + projectToolbarActions: projectActions, getDashboardComponents: (projectFile: string): IDashboardTable[] => { return dashboardComponents; } diff --git a/extensions/data-workspace/src/test/workspaceTreeDataProvider.test.ts b/extensions/data-workspace/src/test/workspaceTreeDataProvider.test.ts index 3588a19b23..9c9f82fe6f 100644 --- a/extensions/data-workspace/src/test/workspaceTreeDataProvider.test.ts +++ b/extensions/data-workspace/src/test/workspaceTreeDataProvider.test.ts @@ -91,7 +91,7 @@ suite('workspaceTreeDataProvider Tests', function (): void { createProject: (name: string, location: vscode.Uri): Promise => { return Promise.resolve(location); }, - projectActions: [{ + projectToolbarActions: [{ id: 'Add', run: async (): Promise => { return Promise.resolve(); } }, diff --git a/extensions/sql-database-projects/src/projectProvider/projectProvider.ts b/extensions/sql-database-projects/src/projectProvider/projectProvider.ts index 39a6f2ed24..7863289c87 100644 --- a/extensions/sql-database-projects/src/projectProvider/projectProvider.ts +++ b/extensions/sql-database-projects/src/projectProvider/projectProvider.ts @@ -85,9 +85,9 @@ export class SqlDatabaseProjectProvider implements dataworkspace.IProjectProvide } /** - * Gets the supported project types + * Gets the project actions to be placed on the dashboard toolbar */ - get projectActions(): (dataworkspace.IProjectAction | dataworkspace.IProjectActionGroup)[] { + get projectToolbarActions(): (dataworkspace.IProjectAction | dataworkspace.IProjectActionGroup)[] { const addItemAction: dataworkspace.IProjectAction = { id: constants.addItemAction, icon: IconPathHelper.add,