ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix object management dialog's validation issue (#22556)

Browse Source 
* fix validation issue

* make message optional

* fix errors
This commit is contained in:
Alan Ren
2023-03-31 07:59:38 -07:00
committed by GitHub
parent e2d4d07c0b
commit 6cc5e9a70d
4 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/mssql/src/objectManagement/ui/objectManagementDialogBase.ts
View File

@@ -198,13 +198,13 @@ export abstract class ObjectManagementDialogBase<ObjectInfoType extends ObjectMa
protected async runValidation(showErrorMessage: boolean = true): Promise<boolean> {
const errors = await this.validateInput();
if (errors.length > 0 && (this.dialogObject.message || showErrorMessage)) {
if (errors.length > 0 && (this.dialogObject.message?.text || showErrorMessage)) {
this.dialogObject.message = {
text: errors.join(EOL),
level: azdata.window.MessageLevel.Error
};
} else {
this.dialogObject.message = { text: '' };
this.dialogObject.message = undefined;
}
return errors.length === 0;
}