ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

SQL Assessment Database Selector (#16030)

Browse Source 
* wip

* wip

* database selector table

* fixed db icon

* wip

* fixed assessment results table

* replaced large query

* fix build error

* updated spacing and other fixes

* removed commented code

* added search bar, fix margins, disable checkbox for offline db

* change width of checkbox column

* changed api to require databases

* Revert "changed api to require databases"

This reverts commit 20fe2d8bd223bae90dfb09609225a1781267a01d.

* removed optional flag from databases parameter

* removed icons on assessment dialog page

* formatting changes, fixed search

* bump STS

* bumped extension version number

* one excludeDbs
This commit is contained in:
Christopher Suh
2021-07-21 20:58:32 -04:00
committed by GitHub
parent f390c4cbc2
commit 6d4608dd8b
11 changed files with 380 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/mssql/config.json
View File

@@ -1,6 +1,6 @@
{
"downloadUrl": "https://github.com/Microsoft/sqltoolsservice/releases/download/v{#version#}/microsoft.sqltools.servicelayer-{#fileName#}",
"version": "3.0.0-release.115",
"version": "3.0.0-release.116",
"downloadFileNames": {
"Windows_86": "win-x86-net5.0.zip",
"Windows_64": "win-x64-net5.0.zip",

5
extensions/mssql/src/contracts.ts
View File

@@ -702,7 +702,7 @@ export namespace SchemaCompareCancellationRequest {
export interface SqlAssessmentParams {
ownerUri: string;
targetType: azdata.sqlAssessment.SqlAssessmentTargetType
targetType: azdata.sqlAssessment.SqlAssessmentTargetType;
}
export interface GenerateSqlAssessmentScriptParams {
@@ -1016,10 +1016,11 @@ export namespace ProfilerSessionCreatedNotification {
/// ------------------------------- <Sql Migration> -----------------------------
export interface SqlMigrationAssessmentParams {
ownerUri: string;
databases: string[];
}
export namespace GetSqlMigrationAssessmentItemsRequest {
export const type = new RequestType<SqlAssessmentParams, mssql.AssessmentResult, void, void>('migration/getassessments');
export const type = new RequestType<SqlMigrationAssessmentParams, mssql.AssessmentResult, void, void>('migration/getassessments');
}
// ------------------------------- <Sql Migration> -----------------------------

2
extensions/mssql/src/mssql.d.ts vendored
View File

@@ -599,5 +599,5 @@ export interface AssessmentResult {
}
export interface ISqlMigrationService {
getAssessments(ownerUri: string): Promise<AssessmentResult | undefined>;
getAssessments(ownerUri: string, databases: string[]): Promise<AssessmentResult | undefined>;
}

4
extensions/mssql/src/sqlMigration/sqlMigrationService.ts
View File

@@ -29,8 +29,8 @@ export class SqlMigrationService implements mssql.ISqlMigrationService {
context.registerService(constants.SqlMigrationService, this);
}
async getAssessments(ownerUri: string): Promise<mssql.AssessmentResult | undefined> {
let params: contracts.SqlMigrationAssessmentParams = { ownerUri: ownerUri };
async getAssessments(ownerUri: string, databases: string[]): Promise<mssql.AssessmentResult | undefined> {
let params: contracts.SqlMigrationAssessmentParams = { ownerUri: ownerUri, databases: databases };
try {
return this.client.sendRequest(contracts.GetSqlMigrationAssessmentItemsRequest.type, params);
}