Add plumbing and simple notebookService tests (#10349)

This commit is contained in:
Chris LaFreniere
2020-05-19 21:36:59 -07:00
committed by GitHub
parent 5136a8b54c
commit 6d710c7144
3 changed files with 105 additions and 4 deletions

View File

@@ -115,8 +115,7 @@ export class NotebookService extends Disposable implements INotebookService {
@IInstantiationService private _instantiationService: IInstantiationService,
@IFileService private readonly _fileService: IFileService,
@ILogService private readonly _logService: ILogService,
@IQueryManagementService private readonly _queryManagementService: IQueryManagementService,
@ILogService private readonly logService: ILogService
@IQueryManagementService private readonly _queryManagementService: IQueryManagementService
) {
super();
this._providersMemento = new Memento('notebookProviders', this._storageService);
@@ -181,7 +180,7 @@ export class NotebookService extends Disposable implements INotebookService {
this._registrationComplete.resolve();
}
private updateRegisteredProviders(p: { id: string; registration: NotebookProviderRegistration; }) {
private updateRegisteredProviders(p: { id: string; registration: NotebookProviderRegistration }) {
let registration = p.registration;
if (!this._providers.has(p.id)) {
@@ -398,7 +397,7 @@ export class NotebookService extends Disposable implements INotebookService {
try {
await this._extensionService.whenInstalledExtensionsRegistered();
} catch (error) {
this.logService.error(error);
this._logService.error(error);
}
instance = await this.waitOnProviderAvailability(providerDescriptor);
} else {