Open books from Github (#10670)

* Add open book option in UI

* Add dropdowns option on dialog

* Add flow logic

* Fetch releases and validate URL

* Add class for github books and shared file books

* Change code structure

* Unblock local copy + stack overflows

* Download books from github

* Remove unused files

* Clean code and use the openNotebookFolder command to open remote book

* Checkpoint

* Refactor remote book dialog model to only hold data

* Remove ApiWrapper and refactor createlocalcopy method

* Use sinon js framework instead of typemoq for testing remotebookController

* Remove api wrapper

* Add some tests

* Add more tests and address pr comments

* Address PR comments

* Fix remotebook broken tests

* Add download location in output channel and use openBook command

* Address PR comments

* Fix typos, print error message and remove failing test

* Print error message

* Separate tests in different files

* Declare controller variable inside extension.tst

Co-authored-by: chlafreniere <hichise@gmail.com>
This commit is contained in:
Barbara Valdez
2020-07-24 19:39:03 -07:00
committed by GitHub
parent 56d1a1c1af
commit 6d9efbd603
17 changed files with 866 additions and 8 deletions

View File

@@ -49,6 +49,11 @@
"items": {
"type": "string"
}
},
"notebook.remoteBookDownloadTimeout": {
"type": "number",
"default": 60000,
"description": "%notebook.remoteBookDownloadTimeout.description%"
}
}
},
@@ -228,6 +233,15 @@
"dark": "resources/dark/open_notebook_inverse.svg",
"light": "resources/light/open_notebook.svg"
}
},
{
"command": "notebook.command.openRemoteBook",
"title": "%title.openRemoteJupyterBook%",
"category": "%books-preview-category%",
"icon": {
"dark": "resources/dark/open_notebook_inverse.svg",
"light": "resources/light/open_notebook.svg"
}
}
],
"languages": [
@@ -421,6 +435,9 @@
"command": "notebook.command.openNotebookFolder",
"when": "view == bookTreeView",
"group": "navigation"
}, {
"command": "notebook.command.openRemoteBook",
"when": "view == bookTreeView"
}
],
"notebook/toolbar": [