ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-03 17:23:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove some vscode differences (#5010)

Browse Source 
* remove some vscode differences

* add dates to todo comments
This commit is contained in:
Anthony Dresser
2019-04-12 21:55:07 -07:00
committed by GitHub
parent c5a32d8373
commit 6dbf757385
25 changed files with 34 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/vs/base/browser/htmlContentRenderer.ts
View File

@@ -171,7 +171,7 @@ export function renderMarkdown(markdown: IMarkdownString, options: RenderOptions
// but update the node with the real result later.
const id = defaultGenerator.nextId();
// {{SQL CARBON EDIT}} - Promise.all not returning the strValue properly in original code?
// {{SQL CARBON EDIT}} - Promise.all not returning the strValue properly in original code? @todo anthonydresser 4/12/19 investigate a better way to do this.
const promise = value.then(strValue => {
withInnerHTML.then(e => {
const span = element.querySelector(`div[data-code="${id}"]`);

5
src/vs/base/browser/ui/button/button.ts
View File

@@ -126,7 +126,7 @@ export class Button extends Disposable {
this.applyStyles();
}
// {{SQL CARBON EDIT}} -- removed 'private' access modifier
// {{SQL CARBON EDIT}} -- removed 'private' access modifier @todo anthonydresser 4/12/19 things needs investigation whether we need this
applyStyles(): void {
if (this._element) {
const background = this.buttonBackground ? this.buttonBackground.toString() : null;
@@ -159,6 +159,7 @@ export class Button extends Disposable {
}
}
// {{SQL CARBON EDIT}} from addClass to addClasses to support multiple classes @todo anthonydresser 4/12/19 invesitgate a better way to do this.
set icon(iconClassName: string) {
DOM.addClasses(this._element, ...iconClassName.split(' '));
}
@@ -227,4 +228,4 @@ export class ButtonGroup extends Disposable {
}
}
}
}
}

4
src/vs/base/browser/ui/contextview/contextview.ts
View File

@@ -273,7 +273,7 @@ export class ContextView extends Disposable {
DOM.hide(this.view);
}
// {{SQL CARBON EDIT}}
// {{SQL CARBON EDIT}} @todo anthonydresser 4/12/19 investigate a better way to do this
public isVisible(): boolean {
return !!this.delegate;
}
@@ -293,4 +293,4 @@ export class ContextView extends Disposable {
super.dispose();
}
}
}

4
src/vs/base/parts/tree/browser/tree.ts
View File

@@ -207,7 +207,7 @@ export interface ITree {
*/
clearFocus(eventPayload?: any): void;
// {{SQL CARBON EDIT}} @todo anthonydresser we need to refactor our code to not need these methods
// {{SQL CARBON EDIT}} @todo anthonydresser 4/12/19 we need to refactor our code to not need these methods
/**
* Adds the trait to elements.
*/
@@ -475,7 +475,7 @@ export interface IDragOverReaction {
autoExpand?: boolean;
}
// {{SQL CARBON EDIT}} @todo anthonydresser refactor to not need this
// {{SQL CARBON EDIT}} @todo anthonydresser 4/12/19 refactor to not need this
export const DRAG_OVER_REJECT: IDragOverReaction = { accept: false };
export const DRAG_OVER_ACCEPT: IDragOverReaction = { accept: true };
export const DRAG_OVER_ACCEPT_BUBBLE_UP: IDragOverReaction = { accept: true, bubble: DragOverBubble.BUBBLE_UP };

2
src/vs/base/parts/tree/browser/treeImpl.ts
View File

@@ -276,7 +276,7 @@ export class Tree implements _.ITree {
this.model.setFocus(null, eventPayload);
}
// {{SQL CARBON EDIT}} @todo anthonydresser we need to refactor our code to not need these methods
// {{SQL CARBON EDIT}} @todo anthonydresser 4/12/19 we need to refactor our code to not need these methods
public addTraits(trait: string, elements: any[]): void {
this.model.addTraits(trait, elements);
}