mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-02-01 17:23:35 -05:00
Remove some vscode differences (#5010)
* remove some vscode differences * add dates to todo comments
This commit is contained in:
@@ -171,7 +171,7 @@ export function renderMarkdown(markdown: IMarkdownString, options: RenderOptions
|
||||
// but update the node with the real result later.
|
||||
const id = defaultGenerator.nextId();
|
||||
|
||||
// {{SQL CARBON EDIT}} - Promise.all not returning the strValue properly in original code?
|
||||
// {{SQL CARBON EDIT}} - Promise.all not returning the strValue properly in original code? @todo anthonydresser 4/12/19 investigate a better way to do this.
|
||||
const promise = value.then(strValue => {
|
||||
withInnerHTML.then(e => {
|
||||
const span = element.querySelector(`div[data-code="${id}"]`);
|
||||
|
||||
@@ -126,7 +126,7 @@ export class Button extends Disposable {
|
||||
this.applyStyles();
|
||||
}
|
||||
|
||||
// {{SQL CARBON EDIT}} -- removed 'private' access modifier
|
||||
// {{SQL CARBON EDIT}} -- removed 'private' access modifier @todo anthonydresser 4/12/19 things needs investigation whether we need this
|
||||
applyStyles(): void {
|
||||
if (this._element) {
|
||||
const background = this.buttonBackground ? this.buttonBackground.toString() : null;
|
||||
@@ -159,6 +159,7 @@ export class Button extends Disposable {
|
||||
}
|
||||
}
|
||||
|
||||
// {{SQL CARBON EDIT}} from addClass to addClasses to support multiple classes @todo anthonydresser 4/12/19 invesitgate a better way to do this.
|
||||
set icon(iconClassName: string) {
|
||||
DOM.addClasses(this._element, ...iconClassName.split(' '));
|
||||
}
|
||||
@@ -227,4 +228,4 @@ export class ButtonGroup extends Disposable {
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -273,7 +273,7 @@ export class ContextView extends Disposable {
|
||||
DOM.hide(this.view);
|
||||
}
|
||||
|
||||
// {{SQL CARBON EDIT}}
|
||||
// {{SQL CARBON EDIT}} @todo anthonydresser 4/12/19 investigate a better way to do this
|
||||
public isVisible(): boolean {
|
||||
return !!this.delegate;
|
||||
}
|
||||
@@ -293,4 +293,4 @@ export class ContextView extends Disposable {
|
||||
|
||||
super.dispose();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user