fix the icon sizing issue (#13522)

This commit is contained in:
Alan Ren
2020-11-23 13:02:52 -08:00
committed by GitHub
parent 21ddf30a7b
commit 6e0a4f27de
4 changed files with 30 additions and 14 deletions

View File

@@ -3,7 +3,6 @@
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import { endsWith } from 'vs/base/common/strings';
import * as types from 'vs/base/common/types';
export function isHidden(element: HTMLElement): boolean {
@@ -22,21 +21,22 @@ export function convertSize(size: number | string | undefined, defaultValue?: st
return defaultValue;
}
let convertedSize: string = size ? size.toString() : defaultValue;
if (!endsWith(convertedSize.toLowerCase(), 'px') && !endsWith(convertedSize.toLowerCase(), '%')) {
convertedSize = convertedSize.toLowerCase();
if (!convertedSize.endsWith('px') && !convertedSize.endsWith('%')) {
convertedSize = convertedSize + 'px';
}
return convertedSize;
}
/**
* Converts a size value into its number representation. Supports px, em and unspecified units.
* Converts a size value into its number representation. Supports px, em and unspecified units.
* @param size The size value to convert
*/
export function convertSizeToNumber(size: number | string | undefined): number {
if (size && typeof (size) === 'string') {
if (endsWith(size.toLowerCase(), 'px')) {
if (size.toLowerCase().endsWith('px')) {
return +size.replace('px', '');
} else if (endsWith(size.toLowerCase(), 'em')) {
} else if (size.toLowerCase().endsWith('em')) {
return +size.replace('em', '') * 11;
}
} else if (!size) {