Fix accessibility issues with Manage Access dialog (#8586)

* Fix accessibility issues with Manage Access dialog

* implement more property interfaces

* Fix lgtm errors

* Simplify condition
This commit is contained in:
Charles Gagnon
2019-12-06 15:09:42 -08:00
committed by GitHub
parent 18ab73cc1d
commit 6e8cc3aaca
14 changed files with 499 additions and 383 deletions

View File

@@ -594,6 +594,14 @@ class ComponentWrapper implements azdata.Component {
this.setProperty('ariaSelected', v);
}
public get ariaHidden(): boolean {
return this.properties['ariaHidden'];
}
public set ariaHidden(v: boolean) {
this.setProperty('ariaHidden', v);
}
public get CSSStyles(): { [key: string]: string } {
return this.properties['CSSStyles'];
}
@@ -771,6 +779,13 @@ class ComponentWithIconWrapper extends ComponentWrapper {
public set iconWidth(v: string | number) {
this.setProperty('iconWidth', v);
}
public get title(): string {
return this.properties['title'];
}
public set title(v: string) {
this.setProperty('title', v);
}
}
class CardWrapper extends ComponentWrapper implements azdata.CardComponent {
@@ -1465,13 +1480,6 @@ class ButtonWrapper extends ComponentWithIconWrapper implements azdata.ButtonCom
this.setProperty('label', v);
}
public get title(): string {
return this.properties['title'];
}
public set title(v: string) {
this.setProperty('title', v);
}
public get onDidClick(): vscode.Event<any> {
let emitter = this._emitterMap.get(ComponentEventType.onDidClick);
return emitter && emitter.event;