ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-18 17:22:45 -05:00
Code Issues Packages Projects Releases Wiki Activity

Removes summary section from plan comparison properties view (#20735)

Browse Source
This commit is contained in:
Lewis Sanchez
2022-10-05 18:48:53 -07:00
committed by GitHub
parent ee386e7382
commit 6ea75bb538
2 changed files with 1 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

84
src/sql/workbench/contrib/executionPlan/browser/executionPlanComparisonPropertiesView.ts
View File

@@ -5,7 +5,6 @@
import { ExecutionPlanPropertiesViewBase, PropertiesSortType } from 'sql/workbench/contrib/executionPlan/browser/executionPlanPropertiesViewBase';
import { IThemeService } from 'vs/platform/theme/common/themeService';
import { isNumber } from 'sql/base/common/numbers';
import * as azdata from 'azdata';
import { localize } from 'vs/nls';
import { iconCssFormatter, textFormatter } from 'sql/base/browser/ui/table/formatters';
@@ -17,7 +16,6 @@ import { executionPlanComparisonPropertiesDifferent } from 'sql/workbench/contri
import * as sqlExtHostType from 'sql/workbench/api/common/sqlExtHostTypes';
import { IContextMenuService, IContextViewService } from 'vs/platform/contextview/browser/contextView';
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { ITextResourcePropertiesService } from 'vs/editor/common/services/textResourceConfigurationService';
import { Codicon } from 'vs/base/common/codicons';
import { deepClone } from 'vs/base/common/objects';
@@ -42,22 +40,6 @@ function getRightOperationLabel(target: string): string {
return localize('nodePropertyViewRightOperation', 'Right operation: {0}', target);
}
function getTopPlanIsGreaterThanBottomPlanSummaryTextTemplate(rowName: string): string {
return localize('nodePropertyViewTopPlanGreaterThanBottomPlan', '{0} is greater for the top plan than it is for the bottom plan.', rowName);
}
function getBottomPlanIsGreaterThanTopPlanSummaryTextTemplate(rowName: string): string {
return localize('nodePropertyViewBottomPlanGreaterThanTopPlan', '{0} is greater for the bottom plan than it is for the top plan.', rowName);
}
function getLeftPlanIsGreaterThanRightPlanSummaryTextTemplate(rowName: string): string {
return localize('nodePropertyViewLeftPlanGreaterThanRightPlan', '{0} is greater for the left plan than it is for the right plan.', rowName);
}
function getRightPlanIsGreaterThanLeftPlanSummaryTextTemplate(rowName: string): string {
return localize('nodePropertyViewRightPlanGreaterThanLeftPlan', '{0} is greater for the right plan than it is for the left plan.', rowName);
}
const notEqualTitle = localize('nodePropertyViewNameNotEqualTitle', 'Not equal to');
const lessThanTitle = localize('nodePropertyViewNameLessThanTitle', 'Less than');
const greaterThanTitle = localize('nodePropertyViewNameGreaterThanTitle', 'Greater than');
@@ -69,7 +51,6 @@ const bottomTitleColumnHeader = localize('nodePropertyViewNameValueColumnBottomH
export class ExecutionPlanComparisonPropertiesView extends ExecutionPlanPropertiesViewBase {
private _model: ExecutionPlanComparisonPropertiesViewModel;
private _summaryTextContainer: HTMLElement;
private _primaryContainer: HTMLElement;
private _secondaryContainer: HTMLElement;
private _orientation: ExecutionPlanCompareOrientation = ExecutionPlanCompareOrientation.Horizontal;
@@ -81,17 +62,13 @@ export class ExecutionPlanComparisonPropertiesView extends ExecutionPlanProperti
@IThemeService themeService: IThemeService,
@IInstantiationService instantiationService: IInstantiationService,
@IContextMenuService contextMenuService: IContextMenuService,
@IContextViewService contextViewService: IContextViewService,
@ITextResourcePropertiesService private readonly textResourcePropertiesService: ITextResourcePropertiesService
@IContextViewService contextViewService: IContextViewService
) {
super(parentContainer, themeService, instantiationService, contextMenuService, contextViewService);
this._model = <ExecutionPlanComparisonPropertiesViewModel>{};
this._parentContainer.style.display = 'none';
const header = DOM.$('.compare-operation-name');
this._summaryTextContainer = DOM.$('.compare-operation-summary-text');
this.setSummary(this._summaryTextContainer);
this._primaryContainer = DOM.$('.compare-operation-name-text');
header.appendChild(this._primaryContainer);
@@ -101,14 +78,6 @@ export class ExecutionPlanComparisonPropertiesView extends ExecutionPlanProperti
this.setHeader(header);
}
private setSummaryElement(summary: string[]): void {
const EOL = this.textResourcePropertiesService.getEOL(undefined);
let summaryText = summary.join(EOL);
let summaryContainerText = localize('executionPlanSummaryForExpensiveOperators', "Summary: {0}{1}", EOL, summaryText);
this._summaryTextContainer.innerText = summaryContainerText;
this._summaryTextContainer.title = summaryContainerText;
}
public setPrimaryElement(e: InternalExecutionPlanElement): void {
this._model.primaryElement = e;
if ((<azdata.executionPlan.ExecutionPlanNode>e).name) {
@@ -176,60 +145,9 @@ export class ExecutionPlanComparisonPropertiesView extends ExecutionPlanProperti
let tableRows = this.convertPropertiesToTableRows(primaryProps, secondaryProps);
tableRows = this.sortPropertiesByDisplayValueEquivalency(tableRows);
this.setSummaryElement(this.getExpensivePropertySummary(tableRows));
this.populateTable(columns, tableRows);
}
/**
* This method returns an array of strings that that will make up the properties summary. The properties summary
* will appear above the properties table when execution plans are being compared.
* Each segment of that summary is in the following generic format:
*
* <row-name> is greater for the top plan than it is for the bottom plan.
* <row-name> is greater for the bottom plan than it is for the top plan.
*
* @param tableRows The table rows that will appear in the properties table.
* @returns The string array containing the segments of the summary.
*/
private getExpensivePropertySummary(tableRows: TableRow[]): string[] {
let summary: string[] = [];
tableRows.forEach(row => {
const rowName = (<RowContent>row.name).text;
if (row.primary && row.secondary) {
const primaryText = row.primary.text.split(' ');
const secondaryTitle = row.secondary.title.split(' ');
if (primaryText.length === secondaryTitle.length && primaryText.length <= 2 && secondaryTitle.length <= 2) {
const MAX_PROPERTY_SUMMARY_LENGTH = 3;
for (let i = 0; i < primaryText.length && summary.length < MAX_PROPERTY_SUMMARY_LENGTH; ++i) {
if (isNumber(primaryText[i]) && isNumber(secondaryTitle[i])) {
const primaryValue = Number(primaryText);
const secondaryValue = Number(secondaryTitle);
let summaryText: string;
if (primaryValue > secondaryValue) {
summaryText = this._orientation === ExecutionPlanCompareOrientation.Horizontal
? getTopPlanIsGreaterThanBottomPlanSummaryTextTemplate(rowName)
: getLeftPlanIsGreaterThanRightPlanSummaryTextTemplate(rowName);
}
else {
summaryText = this._orientation === ExecutionPlanCompareOrientation.Horizontal
? getBottomPlanIsGreaterThanTopPlanSummaryTextTemplate(rowName)
: getRightPlanIsGreaterThanLeftPlanSummaryTextTemplate(rowName);
}
summary.push(summaryText);
}
}
}
}
});
return summary;
}
private getPropertyTableColumns() {
const columns: Slick.Column<Slick.SlickData>[] = [];