Fix ModelView addItem/withItem ordering (#14205)

This commit is contained in:
Charles Gagnon
2021-02-09 08:37:30 -08:00
committed by GitHub
parent 13255f845b
commit 6f192f9af5
2 changed files with 3 additions and 3 deletions

View File

@@ -152,7 +152,7 @@ export class CreateProjectFromDatabaseDialog {
}).component(); }).component();
const connectionRow = view.modelBuilder.flexContainer().withItems([serverLabel, sourceConnectionTextBox], { flex: '0 0 auto', CSSStyles: { 'margin-right': '10px', 'margin-bottom': '-5px', 'margin-top': '-10px' } }).withLayout({ flexFlow: 'row', alignItems: 'center' }).component(); const connectionRow = view.modelBuilder.flexContainer().withItems([serverLabel, sourceConnectionTextBox], { flex: '0 0 auto', CSSStyles: { 'margin-right': '10px', 'margin-bottom': '-5px', 'margin-top': '-10px' } }).withLayout({ flexFlow: 'row', alignItems: 'center' }).component();
connectionRow.insertItem(selectConnectionButton, 2, { CSSStyles: { 'margin-right': '0px', 'margin-bottom': '-5px', 'margin-top': '-10px' } }); connectionRow.addItem(selectConnectionButton, { CSSStyles: { 'margin-right': '0px', 'margin-bottom': '-5px', 'margin-top': '-10px' } });
return connectionRow; return connectionRow;
} }
@@ -293,7 +293,7 @@ export class CreateProjectFromDatabaseDialog {
}).component(); }).component();
const projectLocationRow = view.modelBuilder.flexContainer().withItems([projectLocationLabel, this.projectLocationTextBox], { flex: '0 0 auto', CSSStyles: { 'margin-right': '10px', 'margin-bottom': '-10px' } }).withLayout({ flexFlow: 'row', alignItems: 'center' }).component(); const projectLocationRow = view.modelBuilder.flexContainer().withItems([projectLocationLabel, this.projectLocationTextBox], { flex: '0 0 auto', CSSStyles: { 'margin-right': '10px', 'margin-bottom': '-10px' } }).withLayout({ flexFlow: 'row', alignItems: 'center' }).component();
projectLocationRow.insertItem(browseFolderButton, 2, { CSSStyles: { 'margin-right': '0px', 'margin-bottom': '-10px' } }); projectLocationRow.addItem(browseFolderButton, { CSSStyles: { 'margin-right': '0px', 'margin-bottom': '-10px' } });
return projectLocationRow; return projectLocationRow;
} }

View File

@@ -75,7 +75,7 @@ export abstract class ViewBase extends AngularDisposable implements IModelView {
initial: true initial: true
}; };
}); });
this.addToContainer(component.id, items); this.addToContainer(component.id, items, true);
} }
return descriptor; return descriptor;