remove some vscode differences (#12146)

This commit is contained in:
Anthony Dresser
2020-09-04 18:04:30 -07:00
committed by GitHub
parent 503090856a
commit 704222b8d7
31 changed files with 1118 additions and 66 deletions

View File

@@ -302,7 +302,7 @@ export function appendStylizedStringToContainer(
export function calcANSI8bitColor(colorNumber: number): RGBA | undefined {
if (colorNumber % 1 !== 0) {
// Should be integer
// {{SQL CARBON EDIT}} @todo anthonydresser 4/12/19 this is necessary because we don't use strict null checks
// {{SQL CARBON EDIT}} @todo anthonydresser 4/12/19 this is necessary because we don't use strict-null-checks
return undefined;
} if (colorNumber >= 16 && colorNumber <= 231) {
// Converts to one of 216 RGB colors
@@ -327,7 +327,7 @@ export function calcANSI8bitColor(colorNumber: number): RGBA | undefined {
const colorLevel: number = Math.round(colorNumber / 23 * 255);
return new RGBA(colorLevel, colorLevel, colorLevel);
} else {
// {{SQL CARBON EDIT}} @todo anthonydresser 4/12/19 this is necessary because we don't use strict null checks
// {{SQL CARBON EDIT}} @todo anthonydresser 4/12/19 this is necessary because we don't use strict-null-checks
return undefined;
}
}

View File

@@ -160,9 +160,6 @@ abstract class NotebookAction extends Action2 {
}
const activeCell = editor.getActiveCell();
if (!activeCell) {
return undefined; // {{SQL CARBON EDIT}} strict-null-checks
}
return {
cell: activeCell,

View File

@@ -231,7 +231,6 @@ export class NotebookEditor extends EditorPane {
return group.activeEditorPane._widget.value?.getEditorViewState();
}
}
return undefined; // {{SQL CARBON EDIT}} strict-null-check
}

View File

@@ -192,8 +192,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditor
get activeCodeEditor(): IEditor | undefined {
if (this._isDisposed) {
// {{SQL CARBON EDIT}}
return undefined;
return undefined; // {{SQL CARBON EDIT}} strict-null-check
}
const [focused] = this._list!.getFocusedElements();
@@ -769,14 +768,14 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditor
await this._loadKernelPreloads(this.activeKernel.extensionLocation, this.activeKernel);
if (tokenSource.token.isCancellationRequested) {
return undefined; // {{ SQL CARBON EDIT }}
return undefined; // {{SQL CARBON EDIT}} strict-null-check
}
this._activeKernelResolvePromise = (this.activeKernel as INotebookKernelInfo2).resolve(this.viewModel!.uri, this.getId(), tokenSource.token);
await this._activeKernelResolvePromise;
if (tokenSource.token.isCancellationRequested) {
return undefined; // {{ SQL CARBON EDIT }}
return undefined; // {{SQL CARBON EDIT}} strict-null-check
}
}