From 729378b2d727fe330b17a23a2338edf7813179b3 Mon Sep 17 00:00:00 2001 From: Alex Ma Date: Wed, 14 Oct 2020 08:45:25 -0700 Subject: [PATCH] Null check for updatedetail (#12900) * added null check for options * simplification --- src/vs/base/browser/ui/selectBox/selectBoxCustom.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/base/browser/ui/selectBox/selectBoxCustom.ts b/src/vs/base/browser/ui/selectBox/selectBoxCustom.ts index a77e0c3195..b7abca723a 100644 --- a/src/vs/base/browser/ui/selectBox/selectBoxCustom.ts +++ b/src/vs/base/browser/ui/selectBox/selectBoxCustom.ts @@ -862,8 +862,8 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi private updateDetail(selectedIndex: number): void { this.selectionDetailsPane.innerText = ''; - const description = this.options[selectedIndex].description; - const descriptionIsMarkdown = this.options[selectedIndex].descriptionIsMarkdown; + const description = this.options[selectedIndex]?.description; + const descriptionIsMarkdown = this.options[selectedIndex]?.descriptionIsMarkdown; if (description) { if (descriptionIsMarkdown) {