ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Show message indicating that ADAL is being deprecated (#22432)

Browse Source 
* show message indicating that ADAL is being deprecated

* pr comments update

* added settings deprecation message

* fix deprecation message
This commit is contained in:
Christopher Suh
2023-03-24 14:42:45 -07:00
committed by GitHub
parent 31ac636222
commit 738987c4d5
4 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/azurecore/package.json
View File

@@ -126,7 +126,8 @@
"enumDescriptions": [ "enumDescriptions": [
"Azure Active Directory Authentication Library", "Azure Active Directory Authentication Library",
"Microsoft Authentication Library" "Microsoft Authentication Library"
] ],
"deprecationMessage": "Warning: ADAL has been deprecated, and is scheduled to be removed in a future release. Please use MSAL (default option) instead."
} }
} }
} }

2
extensions/azurecore/src/constants.ts
View File

@@ -68,7 +68,7 @@ export const AzureTokenFolderName = 'Azure Accounts';
export const MSALCacheName = 'accessTokenCache'; export const MSALCacheName = 'accessTokenCache';
export const DefaultAuthLibrary = 'ADAL'; export const DefaultAuthLibrary = 'MSAL';
export enum BuiltInCommands { export enum BuiltInCommands {
SetContext = 'setContext' SetContext = 'setContext'

4
extensions/azurecore/src/extension.ts
View File

@@ -305,6 +305,9 @@ async function onDidChangeConfiguration(e: vscode.ConfigurationChangeEvent): Pro
updatePiiLoggingLevel(); updatePiiLoggingLevel();
} }
if (e.affectsConfiguration('azure.authenticationLibrary')) { if (e.affectsConfiguration('azure.authenticationLibrary')) {
if (vscode.workspace.getConfiguration(Constants.AzureSection).get('authenticationLibrary') === 'ADAL') {
void vscode.window.showInformationMessage(loc.deprecatedOption);
}
await displayReloadAds(); await displayReloadAds();
} }
} }
@@ -327,4 +330,3 @@ async function displayReloadAds(): Promise<boolean> {
} }
} }

2
extensions/azurecore/src/localizedConstants.ts
View File

@@ -66,6 +66,8 @@ export const typeIcon = localize('azurecore.typeIcon', "Type Icon");
export const reloadPrompt = localize('azurecore.reloadPrompt', "Authentication Library has changed, please reload Azure Data Studio."); export const reloadPrompt = localize('azurecore.reloadPrompt', "Authentication Library has changed, please reload Azure Data Studio.");
export const reloadChoice = localize('azurecore.reloadChoice', "Reload Azure Data Studio"); export const reloadChoice = localize('azurecore.reloadChoice', "Reload Azure Data Studio");
export const deprecatedOption = localize('azurecore.deprecated', "Warning: ADAL has been deprecated, and is scheduled to be removed in a future release. Please use MSAL instead.")
// Azure Resource Types // Azure Resource Types
export const sqlServer = localize('azurecore.sqlServer', "SQL server"); export const sqlServer = localize('azurecore.sqlServer', "SQL server");
export const sqlDatabase = localize('azurecore.sqlDatabase', "SQL database"); export const sqlDatabase = localize('azurecore.sqlDatabase', "SQL database");