fixes for #8165, #8167, & #8260 (#8250)

* saving untested work

* fixes for #8165 and #8167

* minor fixes

* fix for #8260

* minor quoting fixes

* fix for #8264

* minor fixes

* minor fixes.

* move tools constants to their own files

* remove execution cell results from notebooks.

* remove extraneous changes

* move ensuring of  StoragePath to platformservice

* remove fix for #8264 pending pm input

extensions/resource-deployment/src/services/tools/azCliTool.ts

@@ -7,11 +7,12 @@ import { SemVer } from 'semver';
 import * as nls from 'vscode-nls';
 import { Command, OsType, ToolType } from '../../interfaces';
 import { IPlatformService } from '../platformService';
-import { ToolBase, dependencyType } from './toolBase';
+import { dependencyType, ToolBase } from './toolBase';
 
 const localize = nls.loadMessageBundle();
 const defaultInstallationRoot = '~/.local/bin';
 const win32InstallationRoot = `${process.env['ProgramFiles(x86)']}\\Microsoft SDKs\\Azure\\CLI2\\wbin`;
+export const AzCliToolName = 'azure-cli';
 
 export class AzCliTool extends ToolBase {
 	constructor(platformService: IPlatformService) {
@@ -19,7 +20,7 @@ export class AzCliTool extends ToolBase {
 	}
 
 	get name(): string {
-		return 'azure-cli';
+		return AzCliToolName;
 	}
 
 	get description(): string {

extensions/resource-deployment/src/services/tools/azdataTool.ts

@@ -13,6 +13,7 @@ import { IPlatformService } from '../platformService';
 import { dependencyType, ToolBase } from './toolBase';
 
 const localize = nls.loadMessageBundle();
+export const AzdataToolName = 'azdata';
 
 export class AzdataTool extends ToolBase {
 	constructor(platformService: IPlatformService) {
@@ -20,7 +21,7 @@ export class AzdataTool extends ToolBase {
 	}
 
 	get name(): string {
-		return 'azdata';
+		return AzdataToolName;
 	}
 
 	get description(): string {

extensions/resource-deployment/src/services/tools/kubeCtlTool.ts

@@ -7,11 +7,12 @@ import { Command, ToolType, OsType } from '../../interfaces';
 import * as nls from 'vscode-nls';
 import { SemVer } from 'semver';
 import { IPlatformService } from '../platformService';
-import { ToolBase, dependencyType } from './toolBase';
+import { dependencyType, ToolBase } from './toolBase';
 
 const localize = nls.loadMessageBundle();
 
 const defaultInstallationRoot = '/usr/local/bin';
+export const KubeCtlToolName = 'kubectl';
 
 export class KubeCtlTool extends ToolBase {
 	constructor(platformService: IPlatformService) {
@@ -19,7 +20,7 @@ export class KubeCtlTool extends ToolBase {
 	}
 
 	get name(): string {
-		return 'kubectl';
+		return KubeCtlToolName;
 	}
 
 	get description(): string {

extensions/resource-deployment/src/services/tools/toolBase.ts

@@ -3,7 +3,7 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 import { EOL } from 'os';
-import { delimiter } from 'path';
+import * as path from 'path';
 import { SemVer, compare } from 'semver';
 import * as vscode from 'vscode';
 import * as nls from 'vscode-nls';
@@ -32,7 +32,7 @@ export const enum dependencyType {
 	Curl = 'Curl'
 }
 
-const pythonAndPip3Localized = localize('deploymentDialog.ToolInformationalMessage.PythonAndPip3', "•	azdata installation needs python3 and pip3 to be pre-installed before necessary tools can be deployed");
+const pythonAndPip3Localized = localize('deploymentDialog.ToolInformationalMessage.PythonAndPip3', "•	azdata installation needs pip3 and python3 version 3.6 to be pre-installed before necessary tools can be deployed");
 const brewLocalized = localize('deploymentDialog.ToolInformationalMessage.Brew', "•	brew is needed for deployment of the tools and needs to be pre-installed before necessary tools can be deployed");
 const curlLocalized = localize('deploymentDialog.ToolInformationalMessage.Curl', "•	curl is needed for installation and needs to be pre-installed before necessary tools can be deployed");
 
@@ -122,12 +122,7 @@ export abstract class ToolBase implements ITool {
 	}
 
 	public get storagePath(): string {
-		const storagePath = this._platformService.storagePath();
-		if (!this._storagePathEnsured) {
-			this._platformService.ensureDirectoryExists(storagePath);
-			this._storagePathEnsured = true;
-		}
-		return storagePath;
+		return this._platformService.storagePath();
 	}
 
 	public get osType(): OsType {
@@ -155,6 +150,7 @@ export abstract class ToolBase implements ITool {
 	public get installationPath(): string {
 		return this._installationPath;
 	}
+
 	protected get installationCommands(): Command[] | undefined {
 		return this.allInstallationCommands.get(this.osType);
 	}
@@ -232,9 +228,9 @@ export abstract class ToolBase implements ITool {
 		this.logToOutputChannel(localize('toolBase.addInstallationSearchPathsToSystemPath.SearchPaths', "Search Paths for tool '{0}': {1}", this.displayName, JSON.stringify(searchPaths, undefined, '\t'))); //this.displayName is localized and searchPaths are OS filesystem paths.
 		searchPaths.forEach(searchPath => {
 			if (process.env.PATH) {
-				if (!`${delimiter}${process.env.PATH}${delimiter}`.includes(`${delimiter}${searchPath}${delimiter}`)) {
-					process.env.PATH += `${delimiter}${searchPath}`;
-					console.log(`Appending to Path -> '${delimiter}${searchPath}'`);
+				if (!`${path.delimiter}${process.env.PATH}${path.delimiter}`.includes(`${path.delimiter}${searchPath}${path.delimiter}`)) {
+					process.env.PATH += `${path.delimiter}${searchPath}`;
+					console.log(`Appending to Path -> '${path.delimiter}${searchPath}'`);
 				}
 			} else {
 				process.env.PATH = searchPath;
@@ -299,7 +295,7 @@ export abstract class ToolBase implements ITool {
 		if (!commandOutput) {
 			throw new Error(`Install location of tool:'${this.displayName}' could not be discovered`);
 		} else {
-			this._installationPath = commandOutput.split(EOL)[0];
+			this._installationPath = path.resolve(commandOutput.split(EOL)[0]);
 		}
 	}
 
@@ -307,7 +303,6 @@ export abstract class ToolBase implements ITool {
 		return this._version ? compare(this._version, new SemVer(version)) >= 0 : false;
 	}
 
-	private _storagePathEnsured: boolean = false;
 	private _status: ToolStatus = ToolStatus.NotInstalled;
 	private _osType: OsType;
 	private _version?: SemVer;