ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-19 09:35:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Connection Store Refactor (#4632)

Browse Source 
* various clean ups

* formatting

* remove linting

* formatting

* IConfigurationService is even better

* messing with connection config tests

* update tests

* formatting

* foramtting

* remove unused code

* add more tests

* working through tests

* formatting

* more factoring of connection store and increase code coverage

* formatting

* fix tests
This commit is contained in:
Anthony Dresser
2019-03-22 01:07:32 -07:00
committed by GitHub
parent 5f637036bc
commit 756f77063a
19 changed files with 896 additions and 1007 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/sql/platform/credentials/common/credentialsService.ts
View File

@@ -25,11 +25,11 @@ export const ICredentialsService = createDecorator<ICredentialsService>(SERVICE_
export interface ICredentialsService {
_serviceBrand: any;
saveCredential(credentialId: string, password: string): Thenable<boolean>;
saveCredential(credentialId: string, password: string): Promise<boolean>;
readCredential(credentialId: string): Thenable<azdata.Credential>;
readCredential(credentialId: string): Promise<azdata.Credential>;
deleteCredential(credentialId: string): Thenable<boolean>;
deleteCredential(credentialId: string): Promise<boolean>;
addEventListener(handle: number, events: CredentialManagementEvents): IDisposable;
}
@@ -62,15 +62,15 @@ export class CredentialsService implements ICredentialsService {
};
}
public saveCredential(credentialId: string, password: string): Thenable<boolean> {
public saveCredential(credentialId: string, password: string): Promise<boolean> {
return this._onServerEventsReady.promise.then(() => this._serverEvents[this._lastHandle].onSaveCredential(credentialId, password));
}
public readCredential(credentialId: string): Thenable<azdata.Credential> {
public readCredential(credentialId: string): Promise<azdata.Credential> {
return this._onServerEventsReady.promise.then(() => this._serverEvents[this._lastHandle].onReadCredential(credentialId));
}
public deleteCredential(credentialId: string): Thenable<boolean> {
public deleteCredential(credentialId: string): Promise<boolean> {
return this._onServerEventsReady.promise.then(() => this._serverEvents[this._lastHandle].onDeleteCredential(credentialId));
}